Page MenuHomePhabricator

holland11 (Patrick Holland)
User

Projects

User does not belong to any projects.

User Details

User Since
May 18 2021, 11:47 AM (10 w, 1 d)

Recent Activity

Today

holland11 committed rGdbed061bf13b: [MCA] Moving the target specific CustomBehaviour impl. from /tools/llvm-mca/ to… (authored by holland11).
[MCA] Moving the target specific CustomBehaviour impl. from /tools/llvm-mca/ to…
Wed, Jul 28, 11:24 AM
holland11 closed D106775: [MCA] Moving the target specific CustomBehaviour impl. from /tools/llvm-mca/ to /lib/Target/..
Wed, Jul 28, 11:23 AM · Restricted Project

Yesterday

holland11 added a comment to D106775: [MCA] Moving the target specific CustomBehaviour impl. from /tools/llvm-mca/ to /lib/Target/..

Have you looked at how per-target stuff of llvm-mca is handled?
Does that also need similar changes? If not, perhaps this can be changed to more closely mimic that instead?

Tue, Jul 27, 1:37 PM · Restricted Project
holland11 updated the diff for D106775: [MCA] Moving the target specific CustomBehaviour impl. from /tools/llvm-mca/ to /lib/Target/..

I have just removed the AMDGPUTargetMCA line from the AMDGPUCodeGen cmake file. I was originally just following the patterns that I saw from the other folders and classes in that directory and then afterwards I went through and tried to remove things that didn't seem necessary. I guess I missed that one.

Tue, Jul 27, 1:11 PM · Restricted Project

Mon, Jul 26

holland11 updated the diff for D106775: [MCA] Moving the target specific CustomBehaviour impl. from /tools/llvm-mca/ to /lib/Target/..
Mon, Jul 26, 3:20 AM · Restricted Project

Sun, Jul 25

holland11 updated the summary of D106775: [MCA] Moving the target specific CustomBehaviour impl. from /tools/llvm-mca/ to /lib/Target/..
Sun, Jul 25, 2:46 PM · Restricted Project
holland11 requested review of D106775: [MCA] Moving the target specific CustomBehaviour impl. from /tools/llvm-mca/ to /lib/Target/..
Sun, Jul 25, 2:43 PM · Restricted Project

Thu, Jul 22

holland11 added a comment to D104730: [MCA] [AMDGPU] Adding CustomBehaviour implementation for AMDGPU..

@andreadb @tstellar Appreciate both of your inputs. I have been working on implementing that setup. Am currently in the process of testing it with the linux shared lib build. If it is working, I'll first submit a patch with the CustomBehaviour changes only (this includes additions to multiple cmake config files to get the CustomBehaviour and InstrPostProcess classes initialized and registered). If/once that's approved and pushed, I'll re-submit this patch but with the new directory structure.

Thu, Jul 22, 8:03 PM · Restricted Project

Tue, Jul 20

holland11 added a comment to D104730: [MCA] [AMDGPU] Adding CustomBehaviour implementation for AMDGPU..

@tstellar @andreadb I've been thinking about the problem for a bit now and have been brainstorming different ideas and digging through the code. I just made a post on the llvm discourse to hopefully get some feedback on the issue (and some potential solutions that I've come up with). If you guys are curious or would be willing to take a look, here's the post https://llvm.discourse.group/t/need-help-deciding-how-to-access-backend-functions-from-within-a-tool/3915 .

Tue, Jul 20, 4:49 PM · Restricted Project

Tue, Jul 13

holland11 added a comment to D104730: [MCA] [AMDGPU] Adding CustomBehaviour implementation for AMDGPU..

We've run into this problem before with some unittests that reference target symbols, so having some kind of static library solution for this would be generally useful.

Tue, Jul 13, 11:10 AM · Restricted Project

Mon, Jul 12

holland11 added a comment to D104730: [MCA] [AMDGPU] Adding CustomBehaviour implementation for AMDGPU..

@holland11 Did you run make check ? The reason I had to update llvm/tools/llvm-mca/CMakeLists.txt was so that the tests pass (without it all invocations of llvm-mca failed with the 'multiple registered command line options' error.

As for a fix, you can export symbols by adding the LLVM_EXTERNAL_VISIBILITY to the function definition, but I don't know if exporting random symbols is necessarily a good idea if it's only needed for an internal tool. Is it possible to rewrite this patch to not use the symbols? Or maybe can we put these symbols into their own static library? We've run into this problem before with some unittests that reference target symbols, so having some kind of static library solution for this would be generally useful.

Mon, Jul 12, 6:20 PM · Restricted Project
holland11 added a comment to D104730: [MCA] [AMDGPU] Adding CustomBehaviour implementation for AMDGPU..

@tstellar You suggested in your original message to add the DISABLE_LLVM_LINK_LLVM_DYLIB to the AMDGPUCustomBehaviour cmake file. This would be a very reasonable solution since, in theory, it would let most of mca still benefit from shared libs. However, when you attempted the fix, you said that to get it to work, you had to also add that flag to the llvm-mca cmake file as well.

Mon, Jul 12, 12:37 PM · Restricted Project

Fri, Jul 9

holland11 added a comment to D104730: [MCA] [AMDGPU] Adding CustomBehaviour implementation for AMDGPU..
Fri, Jul 9, 1:45 PM · Restricted Project
holland11 added a comment to D104730: [MCA] [AMDGPU] Adding CustomBehaviour implementation for AMDGPU..

I add to add DISABLE_LLVM_LINK_LLVM_DYLIB in two places, in llvm/tools/llvm-mca/lib/AMDGPU/CMakeLists.txt as you did in your comment, and also to the add_llvm_tool call in llvm/tools/llvm-mca/CMakeLists.txt. When I did that the tests pass.

Fri, Jul 9, 12:15 PM · Restricted Project

Thu, Jul 8

holland11 added a comment to D104730: [MCA] [AMDGPU] Adding CustomBehaviour implementation for AMDGPU..

@tstellar Would you be willing to test the fix for me? If this request is inappropriate then I can setup a VM and reproduce the error myself then test the fix, but if you're willing to test it for me, that'd be awesome.

Thu, Jul 8, 2:42 PM · Restricted Project
holland11 added a comment to D104730: [MCA] [AMDGPU] Adding CustomBehaviour implementation for AMDGPU..

@tstellar I have been unable to reproduce the error on my machine. I checked out my repo to this commit and tried building with

cmake -GNinja -DCMAKE_BUILD_TYPE=Debug -DLLVM_ENABLE_ASSERTIONS=ON -DLLVM_BUILD_LLVM_DYLIB=ON -DLLVM_LINK_LLVM_DYLIB=ON ../../llvm
ninja

But it built without errors. I then tried the same thing, but with -DLLVM_TARGETS_TO_BUILD="X86" to see if it was related to building without AMDGPU, but that also built without issue.

Thu, Jul 8, 11:29 AM · Restricted Project

Wed, Jul 7

holland11 committed rGd38b9f1f31b1: Revert "[MCA] [AMDGPU] Adding an implementation to AMDGPUCustomBehaviour for… (authored by holland11).
Revert "[MCA] [AMDGPU] Adding an implementation to AMDGPUCustomBehaviour for…
Wed, Jul 7, 8:50 PM
holland11 added a comment to D104730: [MCA] [AMDGPU] Adding CustomBehaviour implementation for AMDGPU..

@tstellar Is it possible that it's the same issue seen https://reviews.llvm.org/D104401 ? In which case, I'd just need to move destructors into the cpp files rather than the .h files?

Wed, Jul 7, 8:43 PM · Restricted Project
holland11 added a comment to D104730: [MCA] [AMDGPU] Adding CustomBehaviour implementation for AMDGPU..

@thakis Hey sorry for not responding quicker. Thanks for taking care of that. I actually don't even know what gn is, but I'll be looking into it so that I can understand what was happening here.

Wed, Jul 7, 8:35 PM · Restricted Project
holland11 committed rGaf3baf1761bb: [MCA] [AMDGPU] Adding an implementation to AMDGPUCustomBehaviour for handling… (authored by holland11).
[MCA] [AMDGPU] Adding an implementation to AMDGPUCustomBehaviour for handling…
Wed, Jul 7, 2:19 PM
holland11 closed D104730: [MCA] [AMDGPU] Adding CustomBehaviour implementation for AMDGPU..
Wed, Jul 7, 2:18 PM · Restricted Project

Tue, Jul 6

holland11 added a comment to D104730: [MCA] [AMDGPU] Adding CustomBehaviour implementation for AMDGPU..

Oh okay, sounds good. I made some changes based on your previous comment so I was just waiting to see if they were good from your perspective. I'll push this tomorrow. Thanks!

Tue, Jul 6, 7:42 PM · Restricted Project
holland11 added a comment to D104730: [MCA] [AMDGPU] Adding CustomBehaviour implementation for AMDGPU..

@foad Any updates?

Tue, Jul 6, 10:26 AM · Restricted Project

Jun 25 2021

holland11 updated the diff for D104730: [MCA] [AMDGPU] Adding CustomBehaviour implementation for AMDGPU..

Removed all lines with s_waitcnt_depctr and added a comment mentioning that we do not currently handle it. Also added a comment explaining why the pseudo instructions are included in the switch statement. Also modified the formatting of one comment block per @foad 's suggestion.

Jun 25 2021, 10:28 AM · Restricted Project
holland11 added a comment to D104730: [MCA] [AMDGPU] Adding CustomBehaviour implementation for AMDGPU..

Please remove all mention of S_WAITCNT_DEPCTR from the patch and then I think it's good to go, thanks again!

Jun 25 2021, 10:13 AM · Restricted Project

Jun 24 2021

holland11 updated the diff for D104730: [MCA] [AMDGPU] Adding CustomBehaviour implementation for AMDGPU..

Updated the previous AMDGPU mca tests and added a new one that highlights the new RetireOOO flag being set globally.

Jun 24 2021, 12:57 PM · Restricted Project
holland11 added a comment to D104730: [MCA] [AMDGPU] Adding CustomBehaviour implementation for AMDGPU..

... could you change this to let SchedModel = SIFullSpeedModel, RetireOOO = 1 and the same for all the other let SchedModel = ... lines? Would that still work? I think that would make it slightly easier for the next person who cut'n'pastes one of these schedmodels to create a new one, to get it right.

Jun 24 2021, 10:31 AM · Restricted Project
holland11 added a comment to D104846: [MCA] Allow unlimited cycles in the timeline view.

+1 Good idea!

Jun 24 2021, 10:09 AM · Restricted Project

Jun 23 2021

holland11 committed rG70040de32d73: [MCA][TimelineView] Fixed a bug that was causing instructions outside of the… (authored by holland11).
[MCA][TimelineView] Fixed a bug that was causing instructions outside of the…
Jun 23 2021, 3:11 PM
holland11 closed D104815: [MCA] [TimelineView] Fixing a bug (that I caused) in TimelineView.cpp that was causing instructions that execute after timeline-max-cycles to still be displayed..
Jun 23 2021, 3:11 PM · Restricted Project
holland11 requested review of D104815: [MCA] [TimelineView] Fixing a bug (that I caused) in TimelineView.cpp that was causing instructions that execute after timeline-max-cycles to still be displayed..
Jun 23 2021, 1:46 PM · Restricted Project
holland11 added a comment to D104730: [MCA] [AMDGPU] Adding CustomBehaviour implementation for AMDGPU..

@foad I implemented some of your suggestions and updated the diff. I did not yet remove the psuedo instruction cases and I did not yet change

else {
    switch (Inst.getOpcode()) {
    case AMDGPU::S_SENDMSG:
    case AMDGPU::S_SENDMSGHALT:
      ScoreBrackets->updateByEvent(TII, TRI, MRI, SQ_MESSAGE, Inst);
      break;
    case AMDGPU::S_MEMTIME:
    case AMDGPU::S_MEMREALTIME:
      ScoreBrackets->updateByEvent(TII, TRI, MRI, SMEM_ACCESS, Inst);
      break;
    }
Jun 23 2021, 1:26 PM · Restricted Project
holland11 updated the diff for D104730: [MCA] [AMDGPU] Adding CustomBehaviour implementation for AMDGPU..

Set the RetireOOO flag globally rather than just on the s_waitcnt instructions. Also got rid of the WriteSALUOOO sched class since s_waitcnt can go back to being in the WriteSALU class.

Jun 23 2021, 1:24 PM · Restricted Project
holland11 updated the summary of D104730: [MCA] [AMDGPU] Adding CustomBehaviour implementation for AMDGPU..
Jun 23 2021, 11:19 AM · Restricted Project
holland11 updated the summary of D104730: [MCA] [AMDGPU] Adding CustomBehaviour implementation for AMDGPU..
Jun 23 2021, 10:49 AM · Restricted Project
holland11 added a comment to D104730: [MCA] [AMDGPU] Adding CustomBehaviour implementation for AMDGPU..

Thanks for doing this! Generally it seems very useful, and my only high level concern is about the way you set RetireOOO only on s_waitcnt instructions. Would it make more sense to set it for all AMDGPU instructions? I'm really not sure what effect this would have. I've never really thought about the concept of "retiring" in our sched model, since it doesn't seem to have any impact on how you should schedule instructions.

Jun 23 2021, 10:27 AM · Restricted Project

Jun 22 2021

holland11 updated the summary of D104730: [MCA] [AMDGPU] Adding CustomBehaviour implementation for AMDGPU..
Jun 22 2021, 5:36 PM · Restricted Project
holland11 updated the summary of D104730: [MCA] [AMDGPU] Adding CustomBehaviour implementation for AMDGPU..
Jun 22 2021, 5:34 PM · Restricted Project
holland11 requested review of D104730: [MCA] [AMDGPU] Adding CustomBehaviour implementation for AMDGPU..
Jun 22 2021, 11:20 AM · Restricted Project
holland11 committed rGd03736455cee: [MCA] [In-order pipeline] Fix for 0 latency instruction causing assertion to… (authored by holland11).
[MCA] [In-order pipeline] Fix for 0 latency instruction causing assertion to…
Jun 22 2021, 10:20 AM
holland11 closed D104675: [MCA] [In-order pipeline] Fix for 0 latency instruction causing assertion to fail..
Jun 22 2021, 10:20 AM · Restricted Project

Jun 21 2021

holland11 requested review of D104675: [MCA] [In-order pipeline] Fix for 0 latency instruction causing assertion to fail..
Jun 21 2021, 5:21 PM · Restricted Project

Jun 17 2021

holland11 committed rGdc11d4e6be24: [MCA] [RegisterFile] Allow for skipping Defs with RegID of 0 (rather than… (authored by holland11).
[MCA] [RegisterFile] Allow for skipping Defs with RegID of 0 (rather than…
Jun 17 2021, 11:53 AM
holland11 closed D104433: [MCA] [RegisterFile] Allow for skipping Defs with RegID of 0 rather than asserting..
Jun 17 2021, 11:53 AM · Restricted Project

Jun 16 2021

holland11 retitled D104433: [MCA] [RegisterFile] Allow for skipping Defs with RegID of 0 rather than asserting. from [MCA] [RegisterFile] Skipping Defs with RegID of 0 rather than asserting. to [MCA] [RegisterFile] Allow for skipping Defs with RegID of 0 rather than asserting..
Jun 16 2021, 7:04 PM · Restricted Project
holland11 retitled D104433: [MCA] [RegisterFile] Allow for skipping Defs with RegID of 0 rather than asserting. from [MCA] Skipping Defs with RegID of 0 rather than asserting. to [MCA] [RegisterFile] Skipping Defs with RegID of 0 rather than asserting..
Jun 16 2021, 7:03 PM · Restricted Project
holland11 requested review of D104433: [MCA] [RegisterFile] Allow for skipping Defs with RegID of 0 rather than asserting..
Jun 16 2021, 7:03 PM · Restricted Project
holland11 added a comment to D104401: [MCA] Anchoring the vtable of CustomBehaviour.

+1 Thanks for catching this!

Jun 16 2021, 11:56 AM · Restricted Project
holland11 added a comment to D104293: [AMDGPU] Set more flags on Real instructions.

I've pushed some patches which should fix all of this: rG323b3e645dd3, rG24ffc343f9da, rG7f3ac6714a56

Jun 16 2021, 10:23 AM · Restricted Project
holland11 updated the diff for D104149: [MCA] Adding the CustomBehaviour class to llvm-mca.

Restructured the way the target macros were being set in the cmake files so that they are properly scoped.

Jun 16 2021, 1:55 AM · Restricted Project

Jun 15 2021

holland11 updated the diff for D104149: [MCA] Adding the CustomBehaviour class to llvm-mca.

Quentin came up with a solution to the build problem and I implemented it. We define macros within /llvm-mca/lib/CMakeLists.txt based on which targets are being built. Then we use those macros within llvm-mca.cpp to guard the includes and references to target specific CBs.

Jun 15 2021, 3:46 PM · Restricted Project
holland11 added a comment to D104149: [MCA] Adding the CustomBehaviour class to llvm-mca.

Good call. I'll work something out and then update the diff once I've tested it properly.

Jun 15 2021, 1:56 PM · Restricted Project
holland11 added a comment to D104149: [MCA] Adding the CustomBehaviour class to llvm-mca.
Jun 15 2021, 1:54 PM · Restricted Project
holland11 updated the diff for D104149: [MCA] Adding the CustomBehaviour class to llvm-mca.

Changed function signature for checkCustomHazard to take ArrayRef<InstRef> rather than const SmallVector<InstRef, 4> &.

Jun 15 2021, 12:36 PM · Restricted Project
holland11 added a comment to D104149: [MCA] Adding the CustomBehaviour class to llvm-mca.

That makes a lot of sense, thank you. Submitting new diff now.

Jun 15 2021, 12:35 PM · Restricted Project
holland11 added a comment to D104149: [MCA] Adding the CustomBehaviour class to llvm-mca.

Yeah, it should be immutable.

Jun 15 2021, 12:08 PM · Restricted Project
holland11 added a comment to D104149: [MCA] Adding the CustomBehaviour class to llvm-mca.

Could the first argument be ArrayRef<InstRef> IssuedInst?

Jun 15 2021, 11:39 AM · Restricted Project
holland11 added a comment to D104293: [AMDGPU] Set more flags on Real instructions.

You may be completely on top of it already, but here is the function that I would like to be able to more or less copy within the AMDGPUCustomBehaviour class. (You don't have to read through the function, I summarize all the flags that get checked below.)

Jun 15 2021, 11:31 AM · Restricted Project
holland11 added a comment to D104149: [MCA] Adding the CustomBehaviour class to llvm-mca.

Okay, the AMDGPU code should be trivial now. The AMDGPUCB should be an empty implementation and the changes to the scheduling model should all have been reverted. I will submit a new patch later on once we get the flags sorted out.

Jun 15 2021, 10:54 AM · Restricted Project
holland11 updated the diff for D104149: [MCA] Adding the CustomBehaviour class to llvm-mca.

Rushed my previous updated diff and it had a mistake.

Jun 15 2021, 10:48 AM · Restricted Project
holland11 updated the diff for D104149: [MCA] Adding the CustomBehaviour class to llvm-mca.

Forgot to revert the AMDGPU scheduling model changes in the previous diff. AMDGPU should be unchanged now and should have an empty AMDGPUCustomBehaviour implementation.

Jun 15 2021, 10:44 AM · Restricted Project
holland11 updated the diff for D104149: [MCA] Adding the CustomBehaviour class to llvm-mca.

Made the AMDGPUCustomBehaviour class empty so that we can commit the implementation in a separate patch. Reverted the if (!RegID) changes back to their original asserts (so that they can be changed in a separate patch as well).

Jun 15 2021, 10:38 AM · Restricted Project

Jun 14 2021

holland11 updated the diff for D104149: [MCA] Adding the CustomBehaviour class to llvm-mca.

clang-format fix.

Jun 14 2021, 5:24 PM · Restricted Project
holland11 updated the diff for D104149: [MCA] Adding the CustomBehaviour class to llvm-mca.

Made some changes suggested by Andrea.

Jun 14 2021, 4:28 PM · Restricted Project
holland11 added a comment to D104149: [MCA] Adding the CustomBehaviour class to llvm-mca.

I just spoke with Quentin, and we both agree with you. If it's alright with @foad, we'd like to push the current patch with the AMDGPU example (after I finish making the modifications Andrea suggested in his first comment). Afterwards, I will submit a bug report regarding the relevant flags not being transferred from pseudo -> real instructions. This will allow me to clean up the cnt detection logic and make it a lot more similar to the logic found in the si-insert-waitcnts pass (which will make the s_waitcnt modelling more accurate).

Jun 14 2021, 12:38 PM · Restricted Project
holland11 added a comment to D104149: [MCA] Adding the CustomBehaviour class to llvm-mca.

I don't like the idea of using your new framework to workaround problems/bugs that are not in llvm-mca.

If you think that there is a genuine bug in their instruction definitions, then please raise a bug for it.

We should never "fix" non-mca issues within mca. This is true in general, and it doesn't only apply to mca. If there is a bug in someone else's code, we create a bug report for it, and optionally we send a patch for it. We don't pretend that the issue doesn't exist, and (worse) hack some workarounds for those bugs in our code.

Jun 14 2021, 11:14 AM · Restricted Project

Jun 13 2021

holland11 added a comment to D104149: [MCA] Adding the CustomBehaviour class to llvm-mca.

Protected fields of InstrPostProcess should be private (even if at the cost of adding const& getters).

Does this hold true in general for objects that get stored in base classes, but used in derived classes? I also have the MCSubtargetInfo, SrcManager, and MCInstrInfo objects within the base CB as protected. Should I change them to private and then use getters for the derived classes to access them?

Jun 13 2021, 11:21 AM · Restricted Project

Jun 12 2021

holland11 added a comment to D104149: [MCA] Adding the CustomBehaviour class to llvm-mca.

@andreadb I appreciate all of the suggestions. They all make sense to me and I'll get started on implementing them.

Jun 12 2021, 7:47 PM · Restricted Project
holland11 updated the diff for D104149: [MCA] Adding the CustomBehaviour class to llvm-mca.

clang-format minor tweak.

Jun 12 2021, 3:10 AM · Restricted Project

Jun 11 2021

holland11 updated the diff for D104149: [MCA] Adding the CustomBehaviour class to llvm-mca.

More clang-tidy warning fixes.

Jun 11 2021, 7:08 PM · Restricted Project
holland11 updated the diff for D104149: [MCA] Adding the CustomBehaviour class to llvm-mca.

Made some modifications to please clang-tidy.

Jun 11 2021, 5:54 PM · Restricted Project
holland11 updated the diff for D104149: [MCA] Adding the CustomBehaviour class to llvm-mca.

Removed some unnecessary includes and fixed header formatting for a few files.

Jun 11 2021, 1:53 PM · Restricted Project
holland11 requested review of D104149: [MCA] Adding the CustomBehaviour class to llvm-mca.
Jun 11 2021, 1:23 PM · Restricted Project

May 19 2021

holland11 added a comment to D102709: [MCA] llvm-mca MCTargetStreamer segfault fix.

@andreadb I seem to have made a mistake with the test file which is causing the commit to fail. I didn't realize I needed to explicitly declare the cpu (-mcpu= argument). I just looked at all of the other tests in the X86 directory and I will be modifying my test file then re-submitting as a new diff. Sorry about that.

Hey Patrick,

don't worry about it. It is already fixed here: https://reviews.llvm.org/rG9acabe8b6ff5

I was keeping an eye at the buildbot page, and I saw the failures after your commit. It is all fixed now :)

May 19 2021, 1:19 PM · Restricted Project
holland11 abandoned D102794: [MCA] llvm-mca MCTargetStreamer segfault fix (Resubmission).
May 19 2021, 1:16 PM · Restricted Project
holland11 updated the summary of D102709: [MCA] llvm-mca MCTargetStreamer segfault fix.
May 19 2021, 1:16 PM · Restricted Project
holland11 updated the summary of D102709: [MCA] llvm-mca MCTargetStreamer segfault fix.
May 19 2021, 11:57 AM · Restricted Project
holland11 requested review of D102794: [MCA] llvm-mca MCTargetStreamer segfault fix (Resubmission).
May 19 2021, 11:55 AM · Restricted Project
holland11 added a comment to D102709: [MCA] llvm-mca MCTargetStreamer segfault fix.

@andreadb I seem to have made a mistake with the test file which is causing the commit to fail. I didn't realize I needed to explicitly declare the cpu (-mcpu= argument). I just looked at all of the other tests in the X86 directory and I will be modifying my test file then re-submitting as a new diff. Sorry about that.

May 19 2021, 11:41 AM · Restricted Project
holland11 added a comment to D102709: [MCA] llvm-mca MCTargetStreamer segfault fix.

Sure. I can commit this patch for you.

What email address do you want me to specify in the author property?

May 19 2021, 10:22 AM · Restricted Project

May 18 2021

holland11 added a comment to D102709: [MCA] llvm-mca MCTargetStreamer segfault fix.

LGTM

Thanks a lot for the detailed explanation.

May 18 2021, 2:13 PM · Restricted Project
holland11 retitled D102709: [MCA] llvm-mca MCTargetStreamer segfault fix from llvm-mca MCTargetStreamer segfault fix to [MCA] llvm-mca MCTargetStreamer segfault fix.
May 18 2021, 12:14 PM · Restricted Project
holland11 updated the summary of D102709: [MCA] llvm-mca MCTargetStreamer segfault fix.
May 18 2021, 12:12 PM · Restricted Project
holland11 requested review of D102709: [MCA] llvm-mca MCTargetStreamer segfault fix.
May 18 2021, 12:06 PM · Restricted Project