This is an archive of the discontinued LLVM Phabricator instance.

Differential D104545

[NFC][libomptarget] Build elf_common with PIC.
ClosedPublic

Authored by vzakhari on Jun 18 2021, 9:01 AM.

Details

Reviewers
tianshilei1992
JonChesterfield
jdoerfert
ronlieb
Commits
rG836992ab9a42: [NFC][libomptarget] Build elf_common with PIC.
Summary

This should fix build failure reported in https://reviews.llvm.org/D103545#2825789

Diff Detail

Event Timeline

vzakhari created this revision.Jun 18 2021, 9:01 AM
Herald added a subscriber: mgorny. · View Herald TranscriptJun 18 2021, 9:01 AM
vzakhari requested review of this revision.Jun 18 2021, 9:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 18 2021, 9:01 AM
Herald added a subscriber: openmp-commits. · View Herald Transcript
vzakhari mentioned this in D103545: [NFC][libomptarget] Reduce the dependency on libelf.Jun 18 2021, 9:02 AM
vzakhari added a reviewer: JonChesterfield.
Herald added a reviewer: jdoerfert. · View Herald TranscriptJun 18 2021, 9:03 AM
Herald added a subscriber: sstefan1. · View Herald Transcript
JonChesterfield accepted this revision.Jun 18 2021, 9:09 AM

Ah, yes. Since all the plugins are shared libraries this seems necessary.

This revision is now accepted and ready to land.Jun 18 2021, 9:09 AM
ronlieb accepted this revision.Jun 18 2021, 9:14 AM
ronlieb added a subscriber: ronlieb.

worked for me

This revision was landed with ongoing or failed builds.Jun 18 2021, 9:21 AM
Closed by commit rG836992ab9a42: [NFC][libomptarget] Build elf_common with PIC. (authored by vzakhari). · Explain Why
This revision was automatically updated to reflect the committed changes.
vzakhari added a commit: rG836992ab9a42: [NFC][libomptarget] Build elf_common with PIC..
Harbormaster completed remote builds in B109943: Diff 353022.Jun 19 2021, 4:07 AM

Revision Contents

PathSize
openmp/
libomptarget/
plugins/
common/
elf_common/
2 lines

Diff 353028

openmp/libomptarget/plugins/common/elf_common/CMakeLists.txt

##===----------------------------------------------------------------------===## ##===----------------------------------------------------------------------===##
# #
# Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. # Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
# See https://llvm.org/LICENSE.txt for license information. # See https://llvm.org/LICENSE.txt for license information.
# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception # SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
# #
##===----------------------------------------------------------------------===## ##===----------------------------------------------------------------------===##
# #
# Common ELF functionality for target plugins # Common ELF functionality for target plugins
# #
##===----------------------------------------------------------------------===## ##===----------------------------------------------------------------------===##
add_library(elf_common OBJECT elf_common.cpp) add_library(elf_common OBJECT elf_common.cpp)
# Build elf_common with PIC to be able to link it with plugin shared libraries.
set_property(TARGET elf_common PROPERTY POSITION_INDEPENDENT_CODE ON)
llvm_update_compile_flags(elf_common) llvm_update_compile_flags(elf_common)
set(LINK_LLVM_LIBS LLVMBinaryFormat LLVMObject LLVMSupport) set(LINK_LLVM_LIBS LLVMBinaryFormat LLVMObject LLVMSupport)
target_link_libraries(elf_common INTERFACE ${LINK_LLVM_LIBS} ${LIBOMPTARGET_DEP_LIBELF_LIBRARIES}) target_link_libraries(elf_common INTERFACE ${LINK_LLVM_LIBS} ${LIBOMPTARGET_DEP_LIBELF_LIBRARIES})
include_directories(${LIBOMPTARGET_LLVM_INCLUDE_DIRS}) include_directories(${LIBOMPTARGET_LLVM_INCLUDE_DIRS})
add_dependencies(elf_common ${LINK_LLVM_LIBS}) add_dependencies(elf_common ${LINK_LLVM_LIBS})
# The code uses Debug.h, which requires threads support. # The code uses Debug.h, which requires threads support.
target_link_libraries(elf_common INTERFACE ${OPENMP_PTHREAD_LIB}) target_link_libraries(elf_common INTERFACE ${OPENMP_PTHREAD_LIB})
# Expose elf_common.h directory to the users of this library. # Expose elf_common.h directory to the users of this library.
target_include_directories(elf_common INTERFACE ${CMAKE_CURRENT_SOURCE_DIR}) target_include_directories(elf_common INTERFACE ${CMAKE_CURRENT_SOURCE_DIR})