This is an archive of the discontinued LLVM Phabricator instance.

[Libomptarget] Add LLVM headers to elf plugin include directories
AbandonedPublic

Authored by jhuber6 on Jun 18 2021, 7:39 AM.

Reviewers

Summary

Libelf depends on LLVM libraries but does not currently add their headers to the include path.

jhuber6 requested review of this revision.Jun 18 2021, 7:39 AM

lgtm, thanks for the fix

This revision is now accepted and ready to land.Jun 18 2021, 7:44 AM

Fixed in D104535.

Path

Size

openmp/

libomptarget/

plugins/

common/

elf_common/

1 line

	Show All 16 Lines
	target_link_libraries(elf_common INTERFACE ${LINK_LLVM_LIBS} ${LIBOMPTARGET_DEP_LIBELF_LIBRARIES})			target_link_libraries(elf_common INTERFACE ${LINK_LLVM_LIBS} ${LIBOMPTARGET_DEP_LIBELF_LIBRARIES})
	add_dependencies(elf_common ${LINK_LLVM_LIBS})			add_dependencies(elf_common ${LINK_LLVM_LIBS})

	# The code uses Debug.h, which requires threads support.			# The code uses Debug.h, which requires threads support.
	target_link_libraries(elf_common INTERFACE ${OPENMP_PTHREAD_LIB})			target_link_libraries(elf_common INTERFACE ${OPENMP_PTHREAD_LIB})

	# Expose elf_common.h directory to the users of this library.			# Expose elf_common.h directory to the users of this library.
	target_include_directories(elf_common INTERFACE ${CMAKE_CURRENT_SOURCE_DIR})			target_include_directories(elf_common INTERFACE ${CMAKE_CURRENT_SOURCE_DIR})
				target_include_directories(elf_common PRIVATE ${LIBOMPTARGET_LLVM_INCLUDE_DIRS})