This is an archive of the discontinued LLVM Phabricator instance.

Improve path remapping in cross-debugging scenarios
ClosedPublic

Authored by aprantl on Jun 16 2021, 11:48 AM.

Details

Summary

This patch implements a slight improvement when debugging across platforms and remapping source paths that are in a non-native format. See the unit test for examples.

rdar://79205675

Diff Detail

Event Timeline

JDevlieghere accepted this revision.Jun 25 2021, 12:52 PM

LGTM with a few nits

lldb/source/Target/PathMappingList.cpp
160

Can we rely on the path being normalized? If not, should this be while instead of if?

204

orig_file?

This revision is now accepted and ready to land.Jun 25 2021, 12:52 PM
This revision was landed with ongoing or failed builds.Jun 29 2021, 3:31 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJun 29 2021, 3:31 PM