Page MenuHomePhabricator

[flang] preserve symbol in DescriptorInquiry
ClosedPublic

Authored by jeanPerier on Jun 16 2021, 7:47 AM.

Details

Summary

Do not use ultimate symbols in DescriptorInquiry. Using the ultimate
symbol may lead to issues later for at least two reasons:

  • The original symbols may have volatile/asynchronous attributes that the ultimate may not have. Later phases working on the DescriptorInquiry would then not apply potential care required by these attributes.
  • HostAssociatedDetails symbols are used by OpenMP for symbols with special OpenMP attributes inside OpenMP region (e.g variables with private attribute), so it is very important to preserve this aspect in the DescriptorInquiry, that would otherwise apply on the symbol outside of the region.

Diff Detail

Event Timeline

jeanPerier created this revision.Jun 16 2021, 7:47 AM
jeanPerier requested review of this revision.Jun 16 2021, 7:47 AM
Herald added a project: Restricted Project. · View Herald Transcript
PeteSteinfeld accepted this revision.Jun 16 2021, 8:32 AM

All builds, tests, and looks good.

This revision is now accepted and ready to land.Jun 16 2021, 8:32 AM
This revision was automatically updated to reflect the committed changes.