This is an archive of the discontinued LLVM Phabricator instance.

Differential D104214

[llvm-dlltool] [test] Remove superfluous --coff-exports option to llvm-readobj. NFC.
ClosedPublic

Authored by mstorsjo on Jun 14 2021, 3:41 AM.

Details

Reviewers
rnk
mati865
Commits
rG08be746728d7: [llvm-dlltool] [test] Remove superfluous --coff-exports option to llvm-readobj.
Summary

The --coff-exports option to llvm-readobj prints the exported symbols
from a DLL/EXE, it doesn't do anything with regards to an import
library.

Diff Detail

Event Timeline

mstorsjo created this revision.Jun 14 2021, 3:41 AM
Herald added subscribers: ormris, steven_wu, hiraditya, inglorion. · View Herald TranscriptJun 14 2021, 3:41 AM
mstorsjo requested review of this revision.Jun 14 2021, 3:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 14 2021, 3:41 AM
Harbormaster completed remote builds in B109067: Diff 351817.Jun 14 2021, 4:31 AM
mati865 accepted this revision.Jun 14 2021, 2:53 PM

LGTM

This revision is now accepted and ready to land.Jun 14 2021, 2:53 PM
Closed by commit rG08be746728d7: [llvm-dlltool] [test] Remove superfluous --coff-exports option to llvm-readobj. (authored by mstorsjo). · Explain WhyJun 17 2021, 3:02 AM
This revision was automatically updated to reflect the committed changes.
mstorsjo added a commit: rG08be746728d7: [llvm-dlltool] [test] Remove superfluous --coff-exports option to llvm-readobj..

Revision Contents

PathSize
llvm/
test/
tools/
llvm-dlltool/
4 lines

Diff 352661

llvm/test/tools/llvm-dlltool/coff-exports.def

; RUN: llvm-dlltool -m i386:x86-64 --input-def %s --output-lib %t.a ; RUN: llvm-dlltool -m i386:x86-64 --input-def %s --output-lib %t.a
; RUN: llvm-readobj --coff-exports %t.a | FileCheck %s ; RUN: llvm-readobj %t.a | FileCheck %s
; RUN: llvm-dlltool -m arm64 --input-def %s --output-lib %t.a ; RUN: llvm-dlltool -m arm64 --input-def %s --output-lib %t.a
; RUN: llvm-readobj --coff-exports %t.a | FileCheck %s ; RUN: llvm-readobj %t.a | FileCheck %s
LIBRARY test.dll LIBRARY test.dll
EXPORTS EXPORTS
TestFunction1 TestFunction1
TestFunction2; TestFunction2;
TestFunction3 ; This is a comment TestFunction3 ; This is a comment
; CHECK: File: test.dll ; CHECK: File: test.dll
Show All 11 Lines