This is an archive of the discontinued LLVM Phabricator instance.

Differential D104213

[llvm-dlltool] [test] Test both short and long forms of options. NFC.
ClosedPublic

Authored by mstorsjo on Jun 14 2021, 3:41 AM.

Details

Reviewers
rnk
mati865
Commits
rG4fe3d5248dfa: [llvm-dlltool] [test] Test both short and long forms of options. NFC.

Diff Detail

Event Timeline

mstorsjo created this revision.Jun 14 2021, 3:41 AM
Herald added subscribers: ormris, steven_wu, hiraditya, inglorion. · View Herald TranscriptJun 14 2021, 3:41 AM
mstorsjo requested review of this revision.Jun 14 2021, 3:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 14 2021, 3:41 AM
Harbormaster completed remote builds in B109066: Diff 351816.Jun 14 2021, 4:50 AM
mati865 accepted this revision.Jun 14 2021, 2:45 PM

LGTM

This revision is now accepted and ready to land.Jun 14 2021, 2:45 PM
Closed by commit rG4fe3d5248dfa: [llvm-dlltool] [test] Test both short and long forms of options. NFC. (authored by mstorsjo). · Explain WhyJun 17 2021, 3:02 AM
This revision was automatically updated to reflect the committed changes.
mstorsjo added a commit: rG4fe3d5248dfa: [llvm-dlltool] [test] Test both short and long forms of options. NFC..

Revision Contents

PathSize
llvm/
test/
tools/
llvm-dlltool/
4 lines

Diff 352660

llvm/test/tools/llvm-dlltool/coff-noname.def

; RUN: llvm-dlltool -k -m i386 --input-def %s --output-lib %t.a ; RUN: llvm-dlltool -k -m i386 -d %s -l %t.a
; RUN: llvm-readobj %t.a | FileCheck %s
; RUN: llvm-dlltool --kill-at --machine i386 --input-def %s --output-lib %t.a
; RUN: llvm-readobj %t.a | FileCheck %s ; RUN: llvm-readobj %t.a | FileCheck %s
LIBRARY test.dll LIBRARY test.dll
EXPORTS EXPORTS
ByOrdinalFunction @ 1 NONAME ByOrdinalFunction @ 1 NONAME
ByNameFunction ByNameFunction
; CHECK: Name type: ordinal ; CHECK: Name type: ordinal
; CHECK-NEXT: Symbol: __imp__ByOrdinalFunction ; CHECK-NEXT: Symbol: __imp__ByOrdinalFunction
; CHECK-NEXT: Symbol: _ByOrdinalFunction ; CHECK-NEXT: Symbol: _ByOrdinalFunction
; CHECK: Name type: noprefix ; CHECK: Name type: noprefix
; CHECK-NEXT: Symbol: __imp__ByNameFunction ; CHECK-NEXT: Symbol: __imp__ByNameFunction
; CHECK-NEXT: Symbol: _ByNameFunction ; CHECK-NEXT: Symbol: _ByNameFunction