This is an archive of the discontinued LLVM Phabricator instance.

[docs][GISel]Added GISel documentation link
ClosedPublic

Authored by pooja2299 on Jun 13 2021, 12:54 PM.

Diff Detail

Unit TestsFailed

Event Timeline

pooja2299 requested review of this revision.Jun 13 2021, 12:54 PM
pooja2299 created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJun 13 2021, 12:54 PM
hiraditya accepted this revision.Jun 13 2021, 1:04 PM
This revision is now accepted and ready to land.Jun 13 2021, 1:04 PM
xgupta accepted this revision.Jun 13 2021, 11:28 PM

lgtm

pooja2299 updated this revision to Diff 351864.Jun 14 2021, 7:18 AM

Removed a syntax error.

xgupta added inline comments.Jun 21 2021, 5:08 AM
llvm/docs/CodeGenerator.rst
731

An space is also needed b/w text and link i.e. GlobalISel and <...>

pooja2299 updated this revision to Diff 353871.Jun 23 2021, 1:10 AM

Added space between text and link

I think it is now ready to commit!
Thanks.

Ok Thanks!
Actually ninja docs-llvm-html is still not working on my computer. Is the patch working fine in your computer? If it is then i will commit it now.

xgupta added a comment.EditedJun 23 2021, 9:40 AM

Yeah, it is working.

Just curious what error message you got while running ninja on your system. You can also use the discord forum if need some help.

This was the same error before.

pooja2299 added a comment.EditedJun 23 2021, 10:59 AM

Yes, they are already installed.

removed extra space after the word 'another'

This revision was landed with ongoing or failed builds.Jun 23 2021, 12:25 PM
This revision was automatically updated to reflect the committed changes.