This is an archive of the discontinued LLVM Phabricator instance.

Differential D104204

[docs][GISel]Added GISel documentation link
ClosedPublic

Authored by pooja2299 on Jun 13 2021, 12:54 PM.

Details

Reviewers
xgupta
gandhi21299
kbarton
hiraditya
Commits
rGa15f9ff996ea: [docs][GISel]Added GISel documentation link
Summary

Added the GISel docs link here - https://llvm.org/docs/CodeGenerator.html#instruction-selection-section

Diff Detail

Unit TestsFailed

TimeTest
41,990 msx64 debian > libFuzzer.libFuzzer::fork.test

Event Timeline

pooja2299 requested review of this revision.Jun 13 2021, 12:54 PM
pooja2299 created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJun 13 2021, 12:54 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
pooja2299 added reviewers: gandhi21299, kbarton.Jun 13 2021, 12:55 PM
hiraditya accepted this revision.Jun 13 2021, 1:04 PM
This revision is now accepted and ready to land.Jun 13 2021, 1:04 PM
Harbormaster completed remote builds in B109031: Diff 351739.Jun 13 2021, 2:08 PM
xgupta accepted this revision.Jun 13 2021, 11:28 PM

lgtm

pooja2299 added a comment.Jun 13 2021, 11:31 PM
In D104204#2816199, @xgupta wrote:

lgtm

Thanks!

pooja2299 updated this revision to Diff 351864.Jun 14 2021, 7:18 AM

Removed a syntax error.

Harbormaster completed remote builds in B109094: Diff 351864.Jun 14 2021, 8:20 AM
xgupta added inline comments.Jun 21 2021, 5:08 AM
llvm/docs/CodeGenerator.rst
731

An space is also needed b/w text and link i.e. GlobalISel and <...>

pooja2299 updated this revision to Diff 353871.Jun 23 2021, 1:10 AM

Added space between text and link

Harbormaster completed remote builds in B110560: Diff 353871.Jun 23 2021, 2:02 AM
xgupta added a comment.Jun 23 2021, 4:11 AM

I think it is now ready to commit!
Thanks.

pooja2299 added a comment.Jun 23 2021, 8:57 AM

Ok Thanks!
Actually ninja docs-llvm-html is still not working on my computer. Is the patch working fine in your computer? If it is then i will commit it now.

xgupta added a comment.EditedJun 23 2021, 9:40 AM

Yeah, it is working.

Just curious what error message you got while running ninja on your system. You can also use the discord forum if need some help.

pooja2299 added a comment.Jun 23 2021, 9:46 AM

This was the same error before.

xgupta added a comment.Jun 23 2021, 10:20 AM

Had you install https://packages.ubuntu.com/bionic/python3-recommonmark using apt get?

pooja2299 added a comment.EditedJun 23 2021, 10:59 AM
In D104204#2836405, @xgupta wrote:

Had you install https://packages.ubuntu.com/bionic/python3-recommonmark using apt get?

Yes, they are already installed.

pooja2299 updated this revision to Diff 354047.Jun 23 2021, 12:10 PM

removed extra space after the word 'another'

This revision was landed with ongoing or failed builds.Jun 23 2021, 12:25 PM
Closed by commit rGa15f9ff996ea: [docs][GISel]Added GISel documentation link (authored by pooja2299). · Explain Why
This revision was automatically updated to reflect the committed changes.
pooja2299 added a commit: rGa15f9ff996ea: [docs][GISel]Added GISel documentation link.
Harbormaster completed remote builds in B110685: Diff 354047.Jun 23 2021, 12:42 PM

Revision Contents

PathSize
llvm/
docs/
3 lines

Diff 351739

llvm/docs/CodeGenerator.rst

Show First 20 Lines • Show All 722 Lines • ▼ Show 20 Lines
well-known ways to do this in the literature. LLVM uses a SelectionDAG based well-known ways to do this in the literature. LLVM uses a SelectionDAG based
instruction selector. instruction selector.
Portions of the DAG instruction selector are generated from the target Portions of the DAG instruction selector are generated from the target
description (``*.td``) files. Our goal is for the entire instruction selector description (``*.td``) files. Our goal is for the entire instruction selector
to be generated from these ``.td`` files, though currently there are still to be generated from these ``.td`` files, though currently there are still
things that require custom C++ code. things that require custom C++ code.
`GlobalISel<https://llvm.org/docs/GlobalISel/index.html>`_\ is another
xguptaUnsubmitted
Not Done
ReplyInline Actions

An space is also needed b/w text and link i.e. GlobalISel and <...>

xgupta: An space is also needed b/w text and link i.e. GlobalISel and <...>
instruction selection framework.
.. _SelectionDAG: .. _SelectionDAG:
Introduction to SelectionDAGs Introduction to SelectionDAGs
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
The SelectionDAG provides an abstraction for code representation in a way that The SelectionDAG provides an abstraction for code representation in a way that
is amenable to instruction selection using automatic techniques is amenable to instruction selection using automatic techniques
(e.g. dynamic-programming based optimal pattern matching selectors). It is also (e.g. dynamic-programming based optimal pattern matching selectors). It is also
▲ Show 20 Lines • Show All 1,963 Lines • Show Last 20 Lines