Page MenuHomePhabricator

[X86] Add ISD::FREEZE and ISD::AssertAlign to the list of opcodes that don't guarantee upper 32 bits are zero.
ClosedPublic

Authored by craig.topper on Jun 11 2021, 11:57 PM.

Details

Summary

The freeze issue was reported here
https://llvm.discourse.group/t/bug-or-feature-freeze-instruction/3639

I don't have a test for AssertAlign. I just noticed it was missing
and assume it should be similar to the other two Asserts.

Diff Detail

Event Timeline

craig.topper created this revision.Jun 11 2021, 11:57 PM
craig.topper requested review of this revision.Jun 11 2021, 11:57 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 11 2021, 11:57 PM
RKSimon accepted this revision.Jun 12 2021, 1:35 AM

LGTM - does this need to be back ported to 12.x?

This revision is now accepted and ready to land.Jun 12 2021, 1:35 AM
pengfei added inline comments.Jun 12 2021, 1:47 AM
llvm/lib/Target/X86/X86InstrCompiler.td
1355–1358

Nit: Should add comments for AssertAlign and FREEZE?

LGTM - does this need to be back ported to 12.x?

Merge request filed as PR50695