This is an archive of the discontinued LLVM Phabricator instance.

[Remarks] Make memsize remarks report as an analysis, not a missed opportunity.
ClosedPublic

Authored by jroelofs on Jun 10 2021, 4:59 PM.

Diff Detail

Event Timeline

jroelofs created this revision.Jun 10 2021, 4:59 PM
jroelofs requested review of this revision.Jun 10 2021, 4:59 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 10 2021, 4:59 PM
thegameg accepted this revision.Jun 21 2021, 5:18 PM

LGTM

llvm/include/llvm/Transforms/Utils/MemoryOpRemark.h
60

Can we reuse enum DiagnosticKind from DiagnosticInfo.h?

DK_OptimizationRemarkMissed,
DK_OptimizationRemarkAnalysis,
This revision is now accepted and ready to land.Jun 21 2021, 5:18 PM
This revision was landed with ongoing or failed builds.Jun 22 2021, 6:23 PM
This revision was automatically updated to reflect the committed changes.