Page MenuHomePhabricator

[SLP]Allow reordering of insertelements.
ClosedPublic

Authored by ABataev on Jun 10 2021, 1:44 PM.

Details

Summary

After we added support for non-ordered insertelements, we can allow
their reordering.

Diff Detail

Event Timeline

ABataev created this revision.Jun 10 2021, 1:44 PM
ABataev requested review of this revision.Jun 10 2021, 1:44 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 10 2021, 1:44 PM
anton-afanasyev accepted this revision.Jun 10 2021, 1:52 PM

LGTM, thanks!

This revision is now accepted and ready to land.Jun 10 2021, 1:52 PM
nikic added a subscriber: nikic.Jun 10 2021, 2:02 PM
nikic added inline comments.
llvm/test/Transforms/SLPVectorizer/X86/external_user_jumbled_load-inseltpoison.ll
15–16

This shouldn't be generating undef. I assume it comes from https://github.com/llvm/llvm-project/blob/5d5b686f6bf6b15b8fbd9ccf957295397f27afc9/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp#L5216, where you can simply omit the explicit UndefValue argument, in which case PoisonValue will be used.

This revision was landed with ongoing or failed builds.Jun 11 2021, 8:48 AM
This revision was automatically updated to reflect the committed changes.