This is an archive of the discontinued LLVM Phabricator instance.

Show First 20 Lines • Show All 5,707 Lines • ▼ Show 20 Lines	if (!User) {
if (auto *VecI = dyn_cast<Instruction>(Vec)) {		if (auto *VecI = dyn_cast<Instruction>(Vec)) {
Builder.SetInsertPoint(VecI->getParent(),		Builder.SetInsertPoint(VecI->getParent(),
std::next(VecI->getIterator()));		std::next(VecI->getIterator()));
} else {		} else {
Builder.SetInsertPoint(&F->getEntryBlock().front());		Builder.SetInsertPoint(&F->getEntryBlock().front());
}		}
Value *NewInst = ExtractAndExtendIfNeeded(Vec);		Value *NewInst = ExtractAndExtendIfNeeded(Vec);
CSEBlocks.insert(cast<Instruction>(Scalar)->getParent());		CSEBlocks.insert(cast<Instruction>(Scalar)->getParent());
auto &Locs = ExternallyUsedValues[Scalar];		auto &NewInstLocs = ExternallyUsedValues[NewInst];
ExternallyUsedValues.insert({NewInst, Locs});		auto It = ExternallyUsedValues.find(Scalar);
		assert(It != ExternallyUsedValues.end() &&
		"Externally used scalar is not found in ExternallyUsedValues");
		NewInstLocs.append(It->second);
ExternallyUsedValues.erase(Scalar);		ExternallyUsedValues.erase(Scalar);
// Required to update internally referenced instructions.		// Required to update internally referenced instructions.
Scalar->replaceAllUsesWith(NewInst);		Scalar->replaceAllUsesWith(NewInst);
continue;		continue;
}		}

// Generate extracts for out-of-tree users.		// Generate extracts for out-of-tree users.
// Find the insertion point for the extractelement lane.		// Find the insertion point for the extractelement lane.
▲ Show 20 Lines • Show All 2,834 Lines • Show Last 20 Lines

llvm/test/Transforms/SLPVectorizer/slp-hr-with-reuse.ll

This file was added.

				; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
				; RUN: opt --passes=slp-vectorizer,instcombine -slp-threshold=-1000000 -S < %s \| FileCheck %s

				define i32 @foo() {
				; CHECK-LABEL: @foo(
				; CHECK-NEXT: entry:
				; CHECK-NEXT: ret i32 -162
				;
				entry:
				%i = xor i32 4, -9
				%i1 = xor i32 5, %i
				%i2 = xor i32 6, %i1
				%i3 = add i32 %i2, 0
				%i4 = add i32 -9, %i3
				%i5 = xor i32 8, -9
				%i6 = add i32 %i5, %i4
				%i7 = xor i32 9, %i5
				%i8 = add i32 %i7, %i6
				%i9 = xor i32 10, %i7
				%i10 = add i32 %i9, %i8
				%i11 = add i32 -9, %i10
				%i12 = xor i32 12, -9
				%i13 = add i32 %i12, %i11
				%i14 = xor i32 13, %i12
				%i15 = add i32 %i14, %i13
				%i16 = xor i32 14, %i14
				%i17 = add i32 %i16, %i15
				%i18 = add i32 -9, %i17
				%i19 = xor i32 16, -9
				%i20 = add i32 %i19, %i18
				%i21 = xor i32 17, %i19
				%i22 = add i32 %i21, %i20
				%i23 = xor i32 18, %i21
				%i24 = add i32 %i23, %i22
				%i25 = add i32 -9, %i24
				%i26 = add i32 0, %i25
				%i27 = add i32 0, %i26
				%i28 = add i32 0, %i27
				%i29 = add i32 -9, %i28
				%i30 = add i32 0, %i29
				%i31 = add i32 0, %i30
				%i32 = add i32 0, %i31
				ret i32 %i32
				}

This is an archive of the discontinued LLVM Phabricator instance.

[SLP] Incorrect handling of external scalar valuesClosedPublic

Details

Diff Detail

Event Timeline

Revision Contents

Diff 352347

llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp

llvm/test/Transforms/SLPVectorizer/slp-hr-with-reuse.ll

[SLP] Incorrect handling of external scalar values
ClosedPublic