Page MenuHomePhabricator

[CMake][Fuchsia] Use PIC for Fuchsia runtimes
ClosedPublic

Authored by phosek on Jun 8 2021, 11:40 AM.

Details

Summary

Disabling PIC globally also disabled PIC for runtimes which was
undesirable, manually override it.

Diff Detail

Event Timeline

phosek created this revision.Jun 8 2021, 11:40 AM
phosek requested review of this revision.Jun 8 2021, 11:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 8 2021, 11:40 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
leonardchan accepted this revision.Jun 8 2021, 11:50 AM

Should _LLVM_ENABLE_PIC ON also be added for the multilibs?

This revision is now accepted and ready to land.Jun 8 2021, 11:50 AM

Should _LLVM_ENABLE_PIC ON also be added for the multilibs?

It should be propagated automatically.

This revision was landed with ongoing or failed builds.Jun 8 2021, 12:30 PM
This revision was automatically updated to reflect the committed changes.