This is an archive of the discontinued LLVM Phabricator instance.

Differential D103915

[docs][llvm-ar] Add rsp-quoting option to the llvm-ar command guide.
ClosedPublic

Authored by gbreynoo on Jun 8 2021, 10:45 AM.

Details

Reviewers
MaskRay
abrachet
rupprecht
jhenderson
Commits
rG3b46283c1539: [docs][llvm-ar] Add rsp-quoting option to the llvm-ar command guide.
Summary

I noticed that I did not update the command guide when introducing the --rsp-quoting option. This change fixes this.

Diff Detail

Event Timeline

gbreynoo requested review of this revision.Jun 8 2021, 10:45 AM
gbreynoo created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJun 8 2021, 10:45 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B108249: Diff 350655.Jun 8 2021, 11:33 AM
MaskRay accepted this revision.Jun 8 2021, 7:51 PM

Thanks!

llvm/docs/CommandGuide/llvm-ar.rst
281
This revision is now accepted and ready to land.Jun 8 2021, 7:51 PM
jhenderson accepted this revision.Jun 8 2021, 11:52 PM
jhenderson added inline comments.
llvm/docs/CommandGuide/llvm-ar.rst
277–283

I believe the other options don't have this space.

282
gbreynoo updated this revision to Diff 350902.Jun 9 2021, 8:04 AM

Fixed whitespace and quotes.

gbreynoo marked 3 inline comments as done.Jun 9 2021, 8:05 AM
Harbormaster completed remote builds in B108421: Diff 350902.Jun 9 2021, 9:03 AM
jhenderson accepted this revision.Jun 10 2021, 12:05 AM
Closed by commit rG3b46283c1539: [docs][llvm-ar] Add rsp-quoting option to the llvm-ar command guide. (authored by gbreynoo). · Explain WhyJun 10 2021, 8:33 AM
This revision was automatically updated to reflect the committed changes.
gbreynoo added a commit: rG3b46283c1539: [docs][llvm-ar] Add rsp-quoting option to the llvm-ar command guide..

Revision Contents

PathSize
llvm/
docs/
CommandGuide/
5 lines

Diff 351184

llvm/docs/CommandGuide/llvm-ar.rst

Show First 20 Lines • Show All 268 Lines • ▼ Show 20 Lines
.. option:: -h, --help .. option:: -h, --help
Print a summary of command-line options and their meanings. Print a summary of command-line options and their meanings.
.. option:: -M .. option:: -M
This option allows for MRI scripts to be read through the standard input This option allows for MRI scripts to be read through the standard input
stream. No other options are compatible with this option. stream. No other options are compatible with this option.
.. option:: --rsp-quoting=<type>
This option selects the quoting style ``<type>`` for response files, either
``posix`` or ``windows``. The default when on Windows is ``windows``, otherwise the
MaskRayUnsubmitted
Done
ReplyInline Actions
This option selects the quoting style ``<type>`` for response files, either
- posix or windows. The default when on Windows is windows, otherwise the
+ ``posix`` or ``windows``. The default when on Windows is ``windows``, otherwise the
default is posix.
MaskRay:
default is ``posix``.
jhendersonUnsubmitted
Done
ReplyInline Actions
posix or windows. The default when on Windows is windows, otherwise the
- default is posix.
+ default is ``posix``.
.. option:: --version
jhenderson:
jhendersonUnsubmitted
Done
ReplyInline Actions
This option allows for MRI scripts to be read through the standard input
stream. No other options are compatible with this option.
-
+
.. option:: --rsp-quoting=<type>

I believe the other options don't have this space.

jhenderson: I believe the other options don't have this space.
.. option:: --version .. option:: --version
Display the version of the :program:`llvm-ar` executable. Display the version of the :program:`llvm-ar` executable.
.. option:: @<FILE> .. option:: @<FILE>
Read command-line options and commands from response file ``<FILE>``. Read command-line options and commands from response file ``<FILE>``.
▲ Show 20 Lines • Show All 61 Lines • Show Last 20 Lines