This is an archive of the discontinued LLVM Phabricator instance.

[MLIR] [Python] Add `owner` to PyValue and fix its parent reference
ClosedPublic

Authored by jdd on Jun 7 2021, 4:40 PM.

Details

Summary

Adds owner python call to mlir.ir.Value.

Assuming that PyValue.parentOperation is intended to be the value's owner, this fixes the construction of it from PyOpOperandList.

Diff Detail

Event Timeline

jdd created this revision.Jun 7 2021, 4:40 PM
jdd requested review of this revision.Jun 7 2021, 4:40 PM
jdd retitled this revision from [MLIR] [Python] Fix parent of PyValue being constructed by PyOpOperandList to [MLIR] [Python] Add `owner` to PyValue and fix its parent reference.Jun 7 2021, 4:44 PM
jdd edited the summary of this revision. (Show Details)
jdd added a reviewer: stellaraccident.
stellaraccident accepted this revision.Jun 14 2021, 9:37 PM

Thanks - this looks right to me.

This revision is now accepted and ready to land.Jun 14 2021, 9:37 PM