Page MenuHomePhabricator

[libc++][nfc] Add more nasty macros.
ClosedPublic

Authored by Mordante on Jun 2 2021, 11:00 AM.

Details

Summary

D101613 added some macros used by Microsofts SAL. D103425 uses __pre
and __post. They are also used by SAL and cause issues when used on
Windows. Add them to the blacklist making it easier to figure out what
the issue is.

Diff Detail

Event Timeline

Mordante requested review of this revision.Jun 2 2021, 11:00 AM
Mordante created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJun 2 2021, 11:00 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Quuxplusone accepted this revision as: Quuxplusone.Jun 2 2021, 11:10 AM
Quuxplusone added inline comments.
libcxx/test/support/nasty_macros.h
66–67

Alphabetize plz. Otherwise LGTM, ship it!

Mordante added inline comments.Jun 2 2021, 11:31 AM
libcxx/test/support/nasty_macros.h
66–67

Good catch, thanks. I had it sorted but a typo in __post, but forgot to resort after fixing it.

cjdb accepted this revision.Jun 2 2021, 12:54 PM
ldionne accepted this revision.Jun 2 2021, 2:53 PM
This revision is now accepted and ready to land.Jun 2 2021, 2:53 PM
This revision was automatically updated to reflect the committed changes.