Page MenuHomePhabricator

[PowerPC] Split tests for constrained intrinsics
ClosedPublic

Authored by sepavloff on May 27 2021, 8:42 AM.

Details

Summary

The test CodeGen/PowerPC/vector-constrained-fp-intrinsics.ll checks code
generation for constrained floating point intrinsics. Many test cases in
it were implemented using operations on constants. Constant folding of
constrained intrinsics would make these test cases almost useless,
because they would check only constant loading.

To keep the tests useful, operations on constants were replaced with
operations on function parameters.

Diff Detail

Event Timeline

sepavloff created this revision.May 27 2021, 8:42 AM
sepavloff requested review of this revision.May 27 2021, 8:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 27 2021, 8:42 AM

Thanks for the good catch! Actually these IR test are originally copied from X86 and SystemZ's. So they should have similar problem.

This patch contains changes requested by reviewers in the review of D102673.

qiucf accepted this revision.May 31 2021, 10:08 AM

LGTM.

This revision is now accepted and ready to land.May 31 2021, 10:08 AM
This revision was landed with ongoing or failed builds.May 31 2021, 10:31 PM
This revision was automatically updated to reflect the committed changes.