This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] All GWS instructions need aligned VGPR on gfx90a
AbandonedPublic

Authored by rampitec on May 26 2021, 3:48 PM.

Details

Reviewers
arsenm
dp
Summary

Fixes: SWDEV-288006

Diff Detail

Event Timeline

rampitec created this revision.May 26 2021, 3:48 PM
rampitec requested review of this revision.May 26 2021, 3:48 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 26 2021, 3:48 PM
Herald added a subscriber: wdng. · View Herald Transcript

This is alternative to D103197, even though I like D103197 better.

rampitec updated this revision to Diff 348375.May 27 2021, 1:38 PM

Fix tidy warnings.

arsenm added inline comments.May 27 2021, 5:52 PM
llvm/lib/Target/AMDGPU/SIInstrInfo.cpp
4678–4692

Why can't you use the same hack as is used for AGPR returns?

rampitec added inline comments.Jun 1 2021, 10:40 AM
llvm/lib/Target/AMDGPU/SIInstrInfo.cpp
4678–4692

How does it help here? The RC is selected correctly, but then operand folding substritutes odd subreg. For that reason I have to handlle it in the isOperandLegal() (here). Remove this code and test gws_init_odd_agpr will fail.

rampitec abandoned this revision.Jun 1 2021, 5:09 PM