This is an archive of the discontinued LLVM Phabricator instance.

Differential D103157

Disable misc-no-recursion checking in Clang
ClosedPublic

Authored by aaron.ballman on May 26 2021, 4:59 AM.

Details

Reviewers
alexfh
njames93
rsmith
erichkeane
Summary

We currently enable misc-no-recursion, but Clang uses recursion intentionally in a fair number of places (like RecursiveASTVisitor). Disabling this check reduces a noise in reviews that add new AST nodes, like https://reviews.llvm.org/D103112#2780747 which has five CI warnings that the author can do nothing about.

Diff Detail

Event Timeline

aaron.ballman requested review of this revision.May 26 2021, 4:59 AM
aaron.ballman created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptMay 26 2021, 4:59 AM
Herald added a subscriber: aheejin. · View Herald Transcript
Harbormaster completed remote builds in B106269: Diff 347926.May 26 2021, 5:38 AM
erichkeane accepted this revision.May 26 2021, 11:00 AM
erichkeane added a subscriber: erichkeane.

I like this, since the entire CFE does a ton of recursion on purpose for all AST related things. Please give others time to disagree however :)

This revision is now accepted and ready to land.May 26 2021, 11:00 AM
aaron.ballman closed this revision.May 27 2021, 7:39 AM

Thanks! I've committed in 767d34e3bdddef6c1871006dd0a2d06a4e1bcd5d.

Revision Contents

PathSize
clang/
2 lines

Diff 347926

clang/.clang-tidy

Checks: '-*,clang-diagnostic-*,llvm-*,misc-*,-misc-unused-parameters,-misc-non-private-member-variables-in-classes,-readability-identifier-naming' Checks: '-*,clang-diagnostic-*,llvm-*,misc-*,-misc-unused-parameters,-misc-non-private-member-variables-in-classes,-readability-identifier-naming,-misc-no-recursion'
# Note that the readability-identifier-naming check is disabled, there are too # Note that the readability-identifier-naming check is disabled, there are too
# many violations in the codebase and they create too much noise in clang-tidy # many violations in the codebase and they create too much noise in clang-tidy
# results. # results.