Page MenuHomePhabricator

[X86][AMX] Fix a bug on tile config.
ClosedPublic

Authored by LuoYuanke on May 26 2021, 2:46 AM.

Details

Summary

The previous code detect if a MBB is bottom block to determine if it is
a backedge of a loop. We should check latch block instead of bottom
block and we should check the header and the bottom block are in the
same loop.

Diff Detail

Event Timeline

LuoYuanke created this revision.May 26 2021, 2:46 AM
LuoYuanke requested review of this revision.May 26 2021, 2:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 26 2021, 2:46 AM
LuoYuanke updated this revision to Diff 347871.May 26 2021, 2:47 AM

Remove tab.

pengfei added inline comments.May 26 2021, 4:45 AM
llvm/test/CodeGen/X86/AMX/amx-gemm.ll
2

The changes look good, but I don't find the problem of the test with the trunk code.
https://godbolt.org/z/63P3446nW
https://godbolt.org/z/T48hefK1W

213–221

These can be removed.

LuoYuanke added inline comments.May 26 2021, 5:17 AM
llvm/test/CodeGen/X86/AMX/amx-gemm.ll
2

I get compiling failure with revision 7ee863b8ebfad92494.

LuoYuanke updated this revision to Diff 347940.May 26 2021, 5:55 AM

Address Pengfei's comments.

pengfei accepted this revision.May 26 2021, 6:08 AM

LGTM. Thanks!

This revision is now accepted and ready to land.May 26 2021, 6:08 AM
This revision was automatically updated to reflect the committed changes.