This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] Fix exception raised during downstream bare-metal libunwind tests
ClosedPublic

Authored by amilendra on May 26 2021, 12:24 AM.

Details

Summary

Fix for the following exception.

AttributeError: 'TestingConfig' object has no attribute 'target_triple'

Related revision: https://reviews.llvm.org/D102012

'TestingConfig' object has no attribute 'target_triple'

Diff Detail

Event Timeline

amilendra created this revision.May 26 2021, 12:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 26 2021, 12:24 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
amilendra requested review of this revision.May 26 2021, 12:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 26 2021, 12:24 AM
miyuki accepted this revision.Jun 7 2021, 5:42 AM

This looks sensible, given that libcxxabi/test/libcxxabi/test/config.py does the same thing:

74         triple = self.get_lit_conf('target_triple', None)
75         if triple is not None:
danielkiss accepted this revision.Jun 15 2021, 12:18 AM
danielkiss added a subscriber: danielkiss.

LGTM

mstorsjo accepted this revision.Jun 15 2021, 4:14 AM
mstorsjo added a subscriber: mstorsjo.

LGTM

This revision is now accepted and ready to land.Jun 15 2021, 4:14 AM