This is an archive of the discontinued LLVM Phabricator instance.

[libomptarget] [amdgpu] Fix copy-paste error setting NumThreads for a corner case.
ClosedPublic

Authored by dhruvachak on May 24 2021, 11:26 AM.

Details

Summary

Fix the case where NumTeams was set incorrectly instead of NumThreads

Diff Detail

Event Timeline

dhruvachak created this revision.May 24 2021, 11:26 AM
dhruvachak requested review of this revision.May 24 2021, 11:26 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 24 2021, 11:26 AM
JonChesterfield accepted this revision.EditedMay 24 2021, 1:19 PM

Could change these to std::min, or add a one line clamp function to avoid repeating either variable

This revision is now accepted and ready to land.May 24 2021, 1:19 PM
This revision was landed with ongoing or failed builds.May 24 2021, 3:24 PM
This revision was automatically updated to reflect the committed changes.