Now that LLDB proper has built-in support for intel-pt traces, we can remove the old plugin written by Intel. It has less features and it's hard to work with.
As a test, I ran "ninja lldbIntelFeatures" and it worked.
Paths
| Differential D102866
[lldb][intel-pt] Remove old plugin ClosedPublic Authored by wallace on May 20 2021, 12:42 PM.
Details Summary Now that LLDB proper has built-in support for intel-pt traces, we can remove the old plugin written by Intel. It has less features and it's hard to work with. As a test, I ran "ninja lldbIntelFeatures" and it worked.
Diff Detail
Event TimelineComment Actions I would be ok with this. Can you track down the original author and add them to the review of this to be sure they aren't using it anymore, and if they need tracing that they have everything they need with your new functionality? Comment Actions I'll contact them again. Last time I did they didn't reply. And btw, this feature was broken for years and last year i revived this plugin, so I imagine no one was using it. And in terms of features, the new implementation supports the same features Comment Actions Btw, lldb-server for a few months hasn't been supporting the functionalities required by the old plugin, and as no one has complained, I imagine it's been not actively used. This revision is now accepted and ready to land.May 27 2021, 11:57 AM Closed by commit rG32bacb74107e: [lldb][intel-pt] Remove old plugin (authored by Walter Erquinigo <wallace@fb.com>). · Explain WhyMay 27 2021, 12:16 PM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 348353 lldb/tools/intel-features/CMakeLists.txt
lldb/tools/intel-features/README.txt
lldb/tools/intel-features/cli-wrapper.cpp
lldb/tools/intel-features/intel-pt/CMakeLists.txt
lldb/tools/intel-features/intel-pt/Decoder.h
lldb/tools/intel-features/intel-pt/Decoder.cpp
lldb/tools/intel-features/intel-pt/PTDecoder.h
lldb/tools/intel-features/intel-pt/PTDecoder.cpp
lldb/tools/intel-features/intel-pt/README_CLI.txt
lldb/tools/intel-features/intel-pt/README_TOOL.txt
lldb/tools/intel-features/intel-pt/cli-wrapper-pt.h
lldb/tools/intel-features/intel-pt/cli-wrapper-pt.cpp
lldb/tools/intel-features/intel-pt/interface/PTDecoder.i
lldb/tools/intel-features/scripts/CMakeLists.txt
lldb/tools/intel-features/scripts/lldb-intel-features.swig
lldb/tools/intel-features/scripts/python-typemaps.txt
|