User Details
- User Since
- Jun 5 2015, 7:27 AM (364 w, 2 h)
Aug 7 2017
Hi Greg .. Can you please review the changes? Please let me know if something needs to be changed. Thanks :)
Jul 26 2017
Changes to make a C++ API work in python modules
- Added a new python typemap to handle it
Jul 20 2017
Jul 6 2017
Removed std::vector<> from public APIs
Jul 5 2017
Hi Greg .. Does it go for the tools built on top of LLDB (e.g. in my case where feature library is not a part of liblldb shared lib but built on top of it)? If yes, then I will proceed to remove std::vector from C++ public API of the tool and create a new class for it.
If you need this via swig for internal kind of stuff, then use a typemap where you map std::vector<T> to a list() with T instances in it in python.
I want to provide a python interface for the tool's C++ public API as well so that the API can be used in python modules as well. Therefore, I think typemapping to list() will not solve the problem. Am I right?
I am a bit confused here as well. Are we exporting a plug-in specific python bindings for the Intel PT data? It seems like it would be nice to wrap this API into the SBTrace or other lldb interface? Am I not understanding this correctly?
Probably, I didn't understand this comment of yours. We are not exporting python binding for Intel PT data. It is a python binding for Tool's C++ API and this Tool is built on top of LLDB. Did I answer your question? Please let me know if I misunderstood your comment.
Jul 4 2017
Hi Pavel .. I could remove all exception handling code from source files. However, I am still wondering how to disable exception handling while providing python functions for C++ APIs of the features. Can you suggest something here? The whole problem is occurring because of the use of vector<> as an argument to one of the C++ APIs. To provide a python interface for these APIs, I am forced to include std_vector.i (please see tools/intel-features/intel-pt/interface/PTDecoder.i file) which is introducing exception handling code.
Removed exception handling code
Jun 29 2017
Thanks for your review Pavel. My comments are inlined. Let me know your opinion :)
Jun 28 2017
Fixed one minor thing in CMakeFile
Cmake files related changes
- Using lldb's cmake functions insted of vanilla ones for cmake files
Hi Pavel .. I have made the changes you suggested. My apologies for misinterpreting your previous comments but during written communications, it is sometimes difficult to interpret everything correctly. I have tried following LLDB's coding conventions and guidelines. Please let me know if I still missed things that you would have liked to see in this patch. Thanks for your patience :)
Jun 26 2017
Changes after feedback
Hi Pavel .. My comments are inlined. Please let me know if you have more concerns. I am submitting the patch with all the proposed changes.
Jun 19 2017
Single feature library development for all intel specific features
May 29 2017
May 26 2017
Updating D33434: Added new API to SBStructuredData class
- Removed inferior from test case (not required)
- fixed enum scope
Thanks for your suggestions. I have made changes according to feedback and submitting it here.
May 24 2017
My comments are inlined. Please let me know if something still needs to be changed.
Updating D33434: Added new API to SBStructuredData class
May 23 2017
May 15 2017
May 10 2017
Abandoning this change due to formatting problem with commit message.
#Updating D33034: Tool for using Intel(R) Processor Trace hardware feature
- Enter a brief description of the changes included in this update.
- The first line is used as subject, next lines as comment. Commit message formatting changes
Sep 9 2016
Already merged it in LLDb repo. So closing this revision.
Sep 8 2016
Removed get() for shared_ptr
Sep 7 2016
Changes based on review
Sep 6 2016
Jul 29 2016
Jul 28 2016
New patch according to review feedback
Hi Greg
Jul 27 2016
Feb 1 2016
source/Plugins/Process/FreeBSD/FreeBSDThread.cpp will not compile for FreeBSD. In Line 576, bp_id is undefined. Please replace it with bp_site_sp->GetID()
Jan 29 2016
Dec 2 2015
Dec 1 2015
Comments Inlined.
Hi Pavel and Tamas
Added Loggings
Hello Greg
Nov 30 2015
Removed assert if ptrace API fails
Nov 27 2015
Nov 13 2015
Nov 12 2015
Hello Jason
Removed log and inserted statement terminator
Used Assert instead of If condition
Nov 2 2015
Oct 12 2015
Oct 9 2015
Oct 6 2015
I thought that the patch can be landed even if one of the reviewers accepts it. Is it so that the patch requires approval from all the reviewers? If that is the case then I am extremely sorry to land it without your approval.
A test was laready present where registers were loaded from lldb command terminal with specific values and then read to compare the values. However, the test still passed because lldb wrote the register values at wrong offsets, but then it read the register values from the same wrong offsets also.
Oct 5 2015
Sep 9 2015
Sep 8 2015
Couldn't land this patch by arc due to merge conflicts. Hence merging it manually and closing this revision.
Sep 7 2015
Clang/GCC generate different assembly for same inferior.
Sep 4 2015
Created a data member in the class to store byte offset of fctrl
Sep 3 2015
Jul 6 2015
Jun 29 2015
Followed up on Jason's comments
Jun 26 2015
If I understood you correctly, you want to add arch.GetTriple().isiOS() also along with arch.GetTriple().isMacOSX(). Am I right ? If yes then I will do it.