This is an archive of the discontinued LLVM Phabricator instance.

[AIX] Add -lc++abi and -lunwind for linking
ClosedPublic

Authored by jasonliu on May 19 2021, 2:18 PM.

Details

Summary

We are going to have libc++abi.a and libunwind.a on AIX.
Add the necessary linking command to pick the libraries up.

Notice that the current change would pass in -lunwind when we are compiling in C mode.
If that's not what we want, then we might want to consider pass -lunwind in AddCXXStdlibLibArgs instead of AddUnwindLibrary.

Diff Detail

Unit TestsFailed

Event Timeline

jasonliu requested review of this revision.May 19 2021, 2:18 PM
jasonliu created this revision.
jasonliu updated this revision to Diff 346601.May 19 2021, 4:53 PM
daltenty accepted this revision.May 20 2021, 10:53 AM

LGTM

(The C case is consistent with the GCC on AIX and clang w/ libc++ on Linux behaviour)

This revision is now accepted and ready to land.May 20 2021, 10:53 AM
This revision was landed with ongoing or failed builds.May 27 2021, 8:49 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMay 27 2021, 8:49 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript