This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Add TLS data segment flag: WASM_SEG_FLAG_TLS
ClosedPublic

Authored by sbc100 on May 10 2021, 3:27 PM.

Details

Summary

Previously the linker was relying solely on the name of the segment
to imply TLS.

Diff Detail

Event Timeline

sbc100 created this revision.May 10 2021, 3:27 PM
sbc100 requested review of this revision.May 10 2021, 3:27 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 10 2021, 3:27 PM
sbc100 retitled this revision from [WebAssembly] Add WASM_SEG_FLAG_TLS to [WebAssembly] Add TLS data segment flag: WASM_SEG_FLAG_TLS.May 10 2021, 4:14 PM
dschuff accepted this revision.May 10 2021, 4:47 PM
dschuff added inline comments.
lld/test/wasm/tls.s
135

I know this is just an explanatory comment, but should these names match the names above?

This revision is now accepted and ready to land.May 10 2021, 4:47 PM
sbc100 added inline comments.May 10 2021, 4:52 PM
lld/test/wasm/tls.s
135

Good catch. The names don't matter to the test because we are testing that they get merged, but yes that is a typo.

sbc100 updated this revision to Diff 344237.May 10 2021, 4:53 PM
  • feedback
sbc100 updated this revision to Diff 344938.May 12 2021, 1:26 PM
  • rebase
This revision was landed with ongoing or failed builds.May 12 2021, 1:31 PM
This revision was automatically updated to reflect the committed changes.