This is an archive of the discontinued LLVM Phabricator instance.

[libcxx][iterator][nfc] acquires lock for working on [range.iter.ops]
ClosedPublic

Authored by cjdb on May 4 2021, 9:33 AM.

Download Raw Diff

Details

Reviewers

ldionne
zoecarver
Mordante

Group Reviewers

Restricted Project

Commits

rG0f803657227d: [libcxx][iterator][nfc] acquires lock for working on [range.iter.ops]

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

cjdb requested review of this revision.May 4 2021, 9:33 AM

cjdb created this revision.

Herald added a project: Restricted Project. · View Herald TranscriptMay 4 2021, 9:33 AM

Herald added a reviewer: Restricted Project. · View Herald Transcript

Herald added a subscriber: libcxx-commits. · View Herald Transcript

Wouldn't it be easier to claim these without a review?
The section changes look good to me.

In D101845#2736627, @Mordante wrote:

Wouldn't it be easier to claim these without a review?
The section changes look good to me.

Putting it up for review gives the listed reviewers time to let the locker know.

Harbormaster completed remote builds in B102557: Diff 342777.May 4 2021, 3:16 PM

I'm not sure how I drew the line in the document for when a section should be split up. In retrospect, it seems like I may have made the wrong decision in a few places. Anyway, this LGTM.

This revision was not accepted when it landed; it landed in state Needs Review.May 19 2021, 11:05 AM

Closed by commit rG0f803657227d: [libcxx][iterator][nfc] acquires lock for working on [range.iter.ops] (authored by cjdb). · Explain Why

This revision was automatically updated to reflect the committed changes.

cjdb added a commit: rG0f803657227d: [libcxx][iterator][nfc] acquires lock for working on [range.iter.ops].

Revision Contents

Path

Size

libcxx/

docs/

OneRangesProposalStatus.csv

8 lines

Diff 342777

libcxx/docs/OneRangesProposalStatus.csv

	Show All 18 Lines
	bidirectional_iterator: `D100278 <https://llvm.org/D100278>`_",			bidirectional_iterator: `D100278 <https://llvm.org/D100278>`_",
	[indirectcallable.indirectinvocable],"indirectly_unary_invocable, indirectly_regular_unary_invocable, indirectly_unary_predicate, indirectly_binary_predicate, indirectly_equivalence_relation, and indirectly_strict_weak_order.","[concepts], [readable.traits]: iter_value_t, [iterator.traits]",,,			[indirectcallable.indirectinvocable],"indirectly_unary_invocable, indirectly_regular_unary_invocable, indirectly_unary_predicate, indirectly_binary_predicate, indirectly_equivalence_relation, and indirectly_strict_weak_order.","[concepts], [readable.traits]: iter_value_t, [iterator.traits]",,,
	[projected],,[iterator.concepts],,,			[projected],,[iterator.concepts],,,
	[common.alg.req]: pt. 1,"indirectly_movable, indirectly_movable_storable, indirectly_copyable, and indirectly_copyable_storable.",[iterator.concepts],,,			[common.alg.req]: pt. 1,"indirectly_movable, indirectly_movable_storable, indirectly_copyable, and indirectly_copyable_storable.",[iterator.concepts],,,
	[common.alg.req]: pt. 2,indirectly_swappable,"[iterator.concepts], [iterator.cust.swap]",,,			[common.alg.req]: pt. 2,indirectly_swappable,"[iterator.concepts], [iterator.cust.swap]",,,
	[common.alg.req]: pt. 3,indirectly_comparable,[projected],,,			[common.alg.req]: pt. 3,indirectly_comparable,[projected],,,
	[common.alg.req]: pt. 4,"Note: could be done with pt. 1. … permutable, mergeable, and sortable",[iterator.concepts],,,			[common.alg.req]: pt. 4,"Note: could be done with pt. 1. … permutable, mergeable, and sortable",[iterator.concepts],,,
	[std.iterator.tags],,[iterator.traits],,,			[std.iterator.tags],,[iterator.traits],,,
	[range.iterator.operations.advance],ranges::advance,[iterator.concepts],,,			[range.iter.op.advance],ranges::advance,[iterator.concepts],Christopher Di Bella,,
	[range.iterator.operations.distance],ranges::distance,"[iterator.concepts], [range.range]",,,			[range.iter.op.distance],ranges::distance,"[iterator.concepts], [range.range]",Christopher Di Bella,,
	[range.iterator.operations.next],ranges::next,[iterator.concepts],,,			[range.iter.op.next],ranges::next,[iterator.concepts],Christopher Di Bella,,
	[range.iterator.operations.prev],ranges::prev,[iterator.concepts],,,			[range.iter.op.prev],ranges::prev,[iterator.concepts],Christopher Di Bella,,
	[predef.iterators],Updates to predefined iterators.,"[iterator.concepts], [iterator.cust.swap], [iterator.cust.move]",,,			[predef.iterators],Updates to predefined iterators.,"[iterator.concepts], [iterator.cust.swap], [iterator.cust.move]",,,
	[move.sentinel],,[concepts] … Note: for testing it may be beneficial to have completed [predef.iterators]. ,,,			[move.sentinel],,[concepts] … Note: for testing it may be beneficial to have completed [predef.iterators]. ,,,
	[common.iterator],,"[iterator.concepts], [iterator.cust.swap], [iterator.cust.move]",,,			[common.iterator],,"[iterator.concepts], [iterator.cust.swap], [iterator.cust.move]",,,
	[default.sentinels],The empty std::default_sentinel_t.,,,,			[default.sentinels],The empty std::default_sentinel_t.,,,,
	[counted.iterator],,"[iterator.concepts], [iterator.cust.swap], [iterator.cust.move], [default.sentinels]",,,			[counted.iterator],,"[iterator.concepts], [iterator.cust.swap], [iterator.cust.move], [default.sentinels]",,,
	[stream.iterators],,[default.sentinels],,,			[stream.iterators],,[default.sentinels],,,
	[ranges.syn]: pt. 1,All the stuff not specified elsewhere. ,"[range.access], [iterator.concepts], [range.all], [range.subrange], unreachable, [range.empty]",,,			[ranges.syn]: pt. 1,All the stuff not specified elsewhere. ,"[range.access], [iterator.concepts], [range.all], [range.subrange], unreachable, [range.empty]",,,
	[ranges.syn]: pt. 2,"iterator_t, sentinel_t, and safe_iterator_t",[range.access],Christopher Di Bella,"`D100255 <https://llvm.org/D100255>`_, `D100269 <https://llvm.org/D100269>`_",			[ranges.syn]: pt. 2,"iterator_t, sentinel_t, and safe_iterator_t",[range.access],Christopher Di Bella,"`D100255 <https://llvm.org/D100255>`_, `D100269 <https://llvm.org/D100269>`_",
	Show All 23 Lines