Page MenuHomePhabricator

[libcxx][iterator][nfc] acquires lock for working on [range.iter.ops]
ClosedPublic

Authored by cjdb on May 4 2021, 9:33 AM.

Diff Detail

Event Timeline

cjdb requested review of this revision.May 4 2021, 9:33 AM
cjdb created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptMay 4 2021, 9:33 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Mordante accepted this revision as: Mordante.May 4 2021, 9:44 AM
Mordante added a subscriber: Mordante.

Wouldn't it be easier to claim these without a review?
The section changes look good to me.

cjdb added a comment.May 4 2021, 10:00 AM

Wouldn't it be easier to claim these without a review?
The section changes look good to me.

Putting it up for review gives the listed reviewers time to let the locker know.

I'm not sure how I drew the line in the document for when a section should be split up. In retrospect, it seems like I may have made the wrong decision in a few places. Anyway, this LGTM.

This revision was not accepted when it landed; it landed in state Needs Review.May 19 2021, 11:05 AM
This revision was automatically updated to reflect the committed changes.