Page MenuHomePhabricator

[Prototype] Introduce attribute for ignoring C++ ABI
AbandonedPublic

Authored by aeubanks on Apr 29 2021, 12:08 PM.

Details

Reviewers
aaron.ballman

Diff Detail

Unit TestsFailed

TimeTest
50 msx64 debian > Clang.Misc::pragma-attribute-supported-attributes-list.test
Script: -- : 'RUN: at line 1'; /mnt/disks/ssd0/agent/llvm-project/build/bin/clang-tblgen -gen-clang-test-pragma-attribute-supported-attributes -I/mnt/disks/ssd0/agent/llvm-project/build/tools/clang/test/../../../../clang/include /mnt/disks/ssd0/agent/llvm-project/build/tools/clang/test/../../../../clang/include/clang/Basic/Attr.td -o - | /mnt/disks/ssd0/agent/llvm-project/build/bin/FileCheck /mnt/disks/ssd0/agent/llvm-project/clang/test/Misc/pragma-attribute-supported-attributes-list.test
60 msx64 windows > Clang.Misc::pragma-attribute-supported-attributes-list.test
Script: -- : 'RUN: at line 1'; c:\ws\w16c2-3\llvm-project\premerge-checks\build\bin\clang-tblgen.exe -gen-clang-test-pragma-attribute-supported-attributes -Ic:\ws\w16c2-3\llvm-project\premerge-checks\build\tools\clang\test\..\..\..\..\clang/include c:\ws\w16c2-3\llvm-project\premerge-checks\build\tools\clang\test\..\..\..\..\clang/include/clang/Basic/Attr.td -o - | c:\ws\w16c2-3\llvm-project\premerge-checks\build\bin\filecheck.exe C:\ws\w16c2-3\llvm-project\premerge-checks\clang\test\Misc\pragma-attribute-supported-attributes-list.test

Event Timeline

aeubanks created this revision.Apr 29 2021, 12:08 PM
aeubanks requested review of this revision.Apr 29 2021, 12:08 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 29 2021, 12:08 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript

Some more background information on the idea would be helpful -- this strikes me as something that should probably start out as an RFC on cfe-dev (and maybe libcxx-dev?) to discuss the high-level goals and approaches, before doing much prototype work. Note: some related attributes are AbiTag and TrivialABI.

I'm first testing out if there are even noticeable benefits to doing this, then if there are I'll put something together to post to cfe-dev. https://crbug.com/1028731 for some background. I'm aware of trivial_abi and will consider wrapping this up into that, although we may want to separate the two.

(I didn't mean to add you as a reviewer yet, Phab automatically did that, you can ignore this for now if you'd like)

I'm first testing out if there are even noticeable benefits to doing this, then if there are I'll put something together to post to cfe-dev. https://crbug.com/1028731 for some background. I'm aware of trivial_abi and will consider wrapping this up into that, although we may want to separate the two.

(I didn't mean to add you as a reviewer yet, Phab automatically did that, you can ignore this for now if you'd like)

Ah, thanks for the info!

I'm first testing out if there are even noticeable benefits to doing this, then if there are I'll put something together to post to cfe-dev. https://crbug.com/1028731 for some background. I'm aware of trivial_abi and will consider wrapping this up into that, although we may want to separate the two.

(I didn't mean to add you as a reviewer yet, Phab automatically did that, you can ignore this for now if you'd like)

FWIW, if you weren't ready for this to be seen by others/reviewed, you can make a draft review (I haven't tested - maybe this is still /accessible/ so you can share a link in an RFC, etc) - discussed here: https://reviews.llvm.org/D99650#2671915

ah I wasn't aware of that, thanks! sorry for the extra noise

Matt added a subscriber: Matt.May 14 2021, 8:28 AM
aeubanks abandoned this revision.May 17 2021, 10:19 AM

turns out this didn't have a good enough impact to pursue