This is an archive of the discontinued LLVM Phabricator instance.

Differential D101417

[CMake][llvm] add missing include to LLVMCheckLinkerFlag
ClosedPublic

Authored by radford on Apr 27 2021, 5:22 PM.

Details

Reviewers
JDevlieghere
Commits
rGe8b3a97ff742: [CMake][llvm] add missing include to LLVMCheckLinkerFlag

Diff Detail

Event Timeline

radford created this revision.Apr 27 2021, 5:22 PM
Herald added a subscriber: mgorny. · View Herald TranscriptApr 27 2021, 5:22 PM
radford requested review of this revision.Apr 27 2021, 5:22 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 27 2021, 5:22 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
This revision was not accepted when it landed; it landed in state Needs Review.Apr 27 2021, 6:53 PM
This revision was landed with ongoing or failed builds.
Closed by commit rGe8b3a97ff742: [CMake][llvm] add missing include to LLVMCheckLinkerFlag (authored by radford, committed by thegameg). · Explain Why
This revision was automatically updated to reflect the committed changes.
thegameg added a commit: rGe8b3a97ff742: [CMake][llvm] add missing include to LLVMCheckLinkerFlag.
thegameg added a subscriber: thegameg.EditedApr 27 2021, 6:54 PM

@JDevlieghere pushing to fix a build failure (https://lab.llvm.org/buildbot/#/builders/149/builds/1934), feel free to still review it!

Harbormaster completed remote builds in B101306: Diff 341035.Apr 27 2021, 8:53 PM

Revision Contents

PathSize
llvm/
cmake/
modules/
1 line

Diff 341052

llvm/cmake/modules/LLVMCheckLinkerFlag.cmake

include(CheckLinkerFlag OPTIONAL) include(CheckLinkerFlag OPTIONAL)
if (COMMAND check_linker_flag) if (COMMAND check_linker_flag)
macro(llvm_check_linker_flag) macro(llvm_check_linker_flag)
check_linker_flag(${ARGN}) check_linker_flag(${ARGN})
endmacro() endmacro()
else() else()
include(CheckCXXCompilerFlag) include(CheckCXXCompilerFlag)
include(CMakePushCheckState)
# cmake builtin compatible, except we assume lang is CXX # cmake builtin compatible, except we assume lang is CXX
function(llvm_check_linker_flag lang flag out_var) function(llvm_check_linker_flag lang flag out_var)
cmake_push_check_state() cmake_push_check_state()
set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} ${flag}") set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} ${flag}")
check_cxx_compiler_flag("" ${out_var}) check_cxx_compiler_flag("" ${out_var})
cmake_pop_check_state() cmake_pop_check_state()
endfunction() endfunction()
endif() endif()