HomePhabricator

[scudo] Enable arm32 arch

Authored by vitalybuka on Tue, Apr 27, 6:33 PM.

Description

[scudo] Enable arm32 arch

Details

Committed
vitalybukaTue, Apr 27, 6:35 PM
Parents
rGe81819377ece: [DSE] Eliminate zero memset after calloc
Branches
Unknown
Tags
Unknown
Reverted By
rG7d0a81ca38e4: Revert "[scudo] Enable arm32 arch"

Event Timeline

@vitalybuka There is a test failing on Armv7: https://lab.llvm.org/buildbot/#/builders/59/builds/1777

******************** TEST 'ScudoStandalone-Unit :: ./ScudoUnitTest-armhf-Test/ScudoSecondaryTest.SecondaryBasic' FAILED ********************
Note: Google Test filter = ScudoSecondaryTest.SecondaryBasic
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from ScudoSecondaryTest
[ RUN      ] ScudoSecondaryTest.SecondaryBasic
/home/tcwg-buildslave/worker/clang-cmake-armv7-full/llvm/compiler-rt/lib/scudo/standalone/tests/secondary_test.cpp:37: Failure
Death test: memset(P, 'A', Size)
    Result: failed to die.
 Error msg:
[  DEATH   ] 
[  FAILED  ] ScudoSecondaryTest.SecondaryBasic (4 ms)
[----------] 1 test from ScudoSecondaryTest (4 ms total)

The test isn't running on our Armv8 32 bit bot, perhaps because ARM32 translates to v7 only, not v8 32 bit. I need to check.

The test passes on an armv8l container so it could be a C library difference? I don't know enough about scudo to say, or find a way to disable this test just for armv7.

I've reverted this since it's still failing. In the past I've marked some tests as expected failures on armv7 but I couldn't find a way to do that for ones written with gtest.

https://lab.llvm.org/buildbot/#/builders/59/builds/1812