On {mips,mipsel,mips64,mips64el}-freebsd, we need to pass any -G option to the assembler.

[dim]

Summary

See also:
https://sourceware.org/binutils/docs/as/MIPS-Options.html#index-g_t_0040code_007b_002dG_007d-option-_0028MIPS_0029-1392

[rnk]

lib/Driver/Tools.cpp

6746–6748

Any reason not to do A->render(Args, CmdArgs);?

[brooks]

Remove a spurious -mcpu from the test case.

[brooks]

I may just not understand how render() works, but I tried it and it didn't seem to work to replace

StringRef v = A->getValue();
CmdArgs.push_back(Args.MakeArgString("-G" + v));

with

A->render(Args, CmdArgs);

lib/Driver/Tools.cpp

6746–6748

I may just not understand how render() works, but I tried it and it didn't seem to work. On annoying thing about -G is that it can work as "-G#" or "-G #" which seems to require the getValue() call to construct a -G# that will work with the assembler.

[dim]

Picking this up, since it needs a minor change to apply.

[dim]

Reapplied to the latest trunk.

[dim]

Add a test for passing -G0 to the assembler.

lib/Driver/Tools.cpp

else if (getToolChain().getArch() == llvm::Triple::mips ||
 
     if (getToolChain().getArch() == llvm::Triple::mips ||
         getToolChain().getArch() == llvm::Triple::cheri ||
         getToolChain().getArch() == llvm::Triple::mips64)
       CmdArgs.push_back("-EB");
     else
       CmdArgs.push_back("-EL");
 
+  if (Arg *A = Args.getLastArg(options::OPT_G)) {
+    StringRef v = A->getValue();
+    CmdArgs.push_back(Args.MakeArgString("-G" + v));
+    A->claim();
+  }
+
     addAssemblerKPIC(Args, CmdArgs);
   } else if (getToolChain().getArch() == llvm::Triple::arm ||
              getToolChain().getArch() == llvm::Triple::armeb ||
              getToolChain().getArch() == llvm::Triple::thumb ||
              getToolChain().getArch() == llvm::Triple::thumbeb) {
     const Driver &D = getToolChain().getDriver();
     const llvm::Triple &Triple = getToolChain().getTriple();
     StringRef FloatABI = arm::getARMFloatABI(D, Args, Triple);

test/Driver/freebsd.c

 // RUN: %clang -target sparc-unknown-freebsd8 %s -### -fpic -no-integrated-as 2>&1 \
 // RUN:   | FileCheck --check-prefix=CHECK-SPARC-PIE %s
 // CHECK-SPARC-PIE: as{{.*}}" "-KPIC
 
 // RUN: %clang -mcpu=ultrasparc -target sparc64-unknown-freebsd8 %s -### -no-integrated-as 2>&1 \
 // RUN:   | FileCheck --check-prefix=CHECK-SPARC-CPU %s
 // CHECK-SPARC-CPU: cc1{{.*}}" "-target-cpu" "ultrasparc"
 // CHECK-SPARC-CPU: as{{.*}}" "-Av9a
+
+// RUN: %clang -mcpu=ultrasparc -target mips-unknown-freebsd8 %s -G0 -### -no-integrated-as 2>&1 \
+// RUN:   | FileCheck --check-prefix=CHECK-MIPS-AS-G0 %s
+// CHECK-MIPS-AS-G0: as{{.*}}" "-G0