This is an archive of the discontinued LLVM Phabricator instance.

Differential D101214

Disable deprecated-copy warnings on various LLVM code to bring the bot back to green
ClosedPublic

Authored by nemanjai on Apr 23 2021, 5:29 PM.

Details

Reviewers
xbolva00
rsmith
Anastasia
vitalybuka
Commits
rG504eee28fe0f: Disable deprecated-copy warnings on various LLVM code to bring the bot back to…
Summary

Bootstrap with -Werror is currently broken due to https://reviews.llvm.org/D79714.
This patch is required to bring the bootstrap bot back to green. The code will likely need to be fixed and the pragmas removed in due time, but for now we need to bring the bot back up.

Bot that is currently failing:
https://lab.llvm.org/buildbot/#/builders/36/builds/7680

Diff Detail

Event Timeline

nemanjai requested review of this revision.Apr 23 2021, 5:29 PM
nemanjai created this revision.
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptApr 23 2021, 5:29 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
nemanjai mentioned this in D79714: [Diagnostics] Restore -Wdeprecated warning when user-declared copy assignment operator is defined as deleted (PR45634).Apr 23 2021, 5:30 PM
nemanjai added a reviewer: Anastasia.
Harbormaster completed remote builds in B100711: Diff 340209.Apr 23 2021, 7:39 PM
vitalybuka accepted this revision.Apr 25 2021, 12:41 PM
This revision is now accepted and ready to land.Apr 25 2021, 12:41 PM
Closed by commit rG504eee28fe0f: Disable deprecated-copy warnings on various LLVM code to bring the bot back to… (authored by nemanjai, committed by vitalybuka). · Explain WhyApr 25 2021, 12:42 PM
This revision was automatically updated to reflect the committed changes.
vitalybuka added a commit: rG504eee28fe0f: Disable deprecated-copy warnings on various LLVM code to bring the bot back to….

Revision Contents

PathSize
llvm/
utils/
unittest/
googlemock/
include/
gmock/
8 lines

Diff 340379

llvm/utils/unittest/googlemock/include/gmock/gmock.h

Show First 20 Lines • Show All 49 Lines • ▼ Show 20 Lines
// .Times(...) ? // .Times(...) ?
// .InSequence(...) * // .InSequence(...) *
// .WillOnce(...) * // .WillOnce(...) *
// .WillRepeatedly(...) ? // .WillRepeatedly(...) ?
// .RetiresOnSaturation() ? ; // .RetiresOnSaturation() ? ;
// //
// where all clauses are optional and WillOnce() can be repeated. // where all clauses are optional and WillOnce() can be repeated.
#ifdef __clang__
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated-copy"
#endif
#include "gmock/gmock-actions.h" #include "gmock/gmock-actions.h"
#include "gmock/gmock-cardinalities.h" #include "gmock/gmock-cardinalities.h"
#include "gmock/gmock-generated-actions.h" #include "gmock/gmock-generated-actions.h"
#include "gmock/gmock-generated-function-mockers.h" #include "gmock/gmock-generated-function-mockers.h"
#include "gmock/gmock-generated-nice-strict.h" #include "gmock/gmock-generated-nice-strict.h"
#include "gmock/gmock-generated-matchers.h" #include "gmock/gmock-generated-matchers.h"
#include "gmock/gmock-matchers.h" #include "gmock/gmock-matchers.h"
#include "gmock/gmock-more-actions.h" #include "gmock/gmock-more-actions.h"
Show All 20 Lines
GTEST_API_ void InitGoogleMock(int* argc, char** argv); GTEST_API_ void InitGoogleMock(int* argc, char** argv);
// This overloaded version can be used in Windows programs compiled in // This overloaded version can be used in Windows programs compiled in
// UNICODE mode. // UNICODE mode.
GTEST_API_ void InitGoogleMock(int* argc, wchar_t** argv); GTEST_API_ void InitGoogleMock(int* argc, wchar_t** argv);
} // namespace testing } // namespace testing
#ifdef __clang__
#pragma clang diagnostic pop
#endif
#endif // GMOCK_INCLUDE_GMOCK_GMOCK_H_ #endif // GMOCK_INCLUDE_GMOCK_GMOCK_H_