Page MenuHomePhabricator

[clang][nfc] Split getOrCheckAMDGPUCodeObjectVersion
AbandonedPublic

Authored by JonChesterfield on Thu, Apr 22, 3:42 PM.

Details

Reviewers
yaxunl
Summary

[clang][nfc] Split getOrCheckAMDGPUCodeObjectVersion

Separates detection of deprecated or invalid code object version from
returning the version. Alternative to D101077.

Diff Detail

Unit TestsFailed

TimeTest
0 msx64 debian > libomptarget.mapping::declare_mapper_nested_default_mappers_array.cpp
Script: -- : 'RUN: at line 1'; echo ignored-command

Event Timeline

JonChesterfield requested review of this revision.Thu, Apr 22, 3:42 PM
Herald added a project: Restricted Project. · View Herald TranscriptThu, Apr 22, 3:42 PM

I'm not very pleased with this. There's too much state to move around when representing the failure and the control flow is probably harder to read than it was in the original. May take another pass at it.

yaxunl accepted this revision.Thu, Apr 22, 3:49 PM

nice. Thanks.

This revision is now accepted and ready to land.Thu, Apr 22, 3:49 PM

I'm not very pleased with this. There's too much state to move around when representing the failure and the control flow is probably harder to read than it was in the original. May take another pass at it.

I am OK with this. If you would like to try more pls go ahead.

JonChesterfield abandoned this revision.EditedThu, Apr 22, 3:50 PM

Abandoning this. Unacceptably ugly, will revise D101077 in a slightly different direction.

edit: love the race condition in the comments, just testing an alternative now

  • factor out last arg wins
This revision is now accepted and ready to land.Thu, Apr 22, 3:57 PM
JonChesterfield abandoned this revision.Fri, Apr 23, 12:44 PM