Page MenuHomePhabricator

[mlir] Template helper for analyses with dependencies
AbandonedPublic

Authored by Hardcode84 on Apr 22 2021, 2:54 AM.

Details

Reviewers
rriddle

Diff Detail

Event Timeline

Hardcode84 created this revision.Apr 22 2021, 2:54 AM
Hardcode84 requested review of this revision.Apr 22 2021, 2:54 AM

FIx copypaste in license header

rriddle added inline comments.Apr 23 2021, 11:02 AM
mlir/include/mlir/Pass/AnalysisUtilities.h
28

Why not just add a variadic areAllPreserved method to PreservedAnalyses? With that, this additional class doesn't hold as much weight IMO.

Hardcode84 abandoned this revision.Apr 23 2021, 11:36 AM
Hardcode84 added inline comments.
mlir/include/mlir/Pass/AnalysisUtilities.h
28

Yeah, probably you are right