[FuncAttrs] Don't infer willreturn for nonexact definitions

[sstefan1]

Summary

Fix for PR50047

Discovered during attributor testing comparing stats with
and without the attributor. Willreturn should not be inferred
for nonexact definitions.

[jdoerfert]

LG

llvm/lib/Transforms/IPO/FunctionAttrs.cpp

if (none_of(*F, basicBlockCanReturn)) {
       Changed = true;
     }
   }
 
   return Changed;
 }
 
 static bool functionWillReturn(const Function &F) {
+  // We can infer and propagate function attributes only when we know that the
+  // definition we'll get at link time is *exactly* the definition we see now.
+  // For more details, see GlobalValue::mayBeDerefined.
+  if (!F.hasExactDefinition())
+    return false;
+
   // Must-progress function without side-effects must return.
   if (F.mustProgress() && F.onlyReadsMemory())
     return true;
 
   // Can only analyze functions with a definition.
   if (F.isDeclaration())
     return false;
 

llvm/test/Transforms/FunctionAttrs/willreturn.ll

 
 bb1:
   br label %bb2
 
 bb2:
   br label %bb1
 }
 
+define linkonce i32 @square(i32) {
+; CHECK-NOT: Function Attrs: {{.*}}willreturn
+; CHECK: define linkonce i32 @square(
+    %2 = mul nsw i32 %0, %0
+    ret i32 %2
+}
+
 declare i64 @fn_noread() readnone
 declare void @fn_willreturn() willreturn