This is an archive of the discontinued LLVM Phabricator instance.

Differential D100986

[libc++][AIX] Define _LIBCPP_ELAST
ClosedPublic

Authored by jasonliu on Apr 21 2021, 12:01 PM.

Details

Reviewers
sfertile
xingxue
SeanP
zibi
ldionne
Group Reviewers
Restricted Project
Commits
rG4677d795b204: [libc++][AIX] Define _LIBCPP_ELAST
Summary

The aim is to define _LIBCPP_ELAST for AIX since strerror/strerror_r can't handle out-of-range errno values.

Diff Detail

Unit TestsFailed

TimeTest
1,080 mslibcxx CI C++20 > libc++.std/containers/associative/map::iterator_concept_conformance.compile.pass.cpp
1,080 mslibcxx CI C++20 > libc++.std/containers/associative/multimap::iterator_concept_conformance.compile.pass.cpp
1,030 mslibcxx CI C++20 > libc++.std/containers/associative/multiset::iterator_concept_conformance.compile.pass.cpp
1,020 mslibcxx CI C++20 > libc++.std/containers/associative/set::iterator_concept_conformance.compile.pass.cpp
930 mslibcxx CI C++20 > libc++.std/containers/sequences/array::iterator_concept_conformance.compile.pass.cpp
View Full Test Results (68 Failed)

Event Timeline

jasonliu requested review of this revision.Apr 21 2021, 12:01 PM
jasonliu created this revision.
SeanP added inline comments.Apr 21 2021, 9:06 PM
libcxx/src/include/config_elast.h
43

AIX has sys_nerr. It would be better to use that.

Harbormaster completed remote builds in B100063: Diff 339337.Apr 22 2021, 12:18 AM
jasonliu added inline comments.Apr 22 2021, 9:17 AM
libcxx/src/include/config_elast.h
43

@SeanP sys_nerr is guarded by _ALL_SOURCE and it's a BSD extension. Since this is a header could potentially included by any source file, the _ALL_SOURCE requirement for building the source could get viral. I think we should decrease our exposure on needing _ALL_SOURCE to build the source.

jasonliu updated this revision to Diff 341201.Apr 28 2021, 7:33 AM

rebase to clean the pre-commit ci

Harbormaster completed remote builds in B101418: Diff 341201.Apr 28 2021, 9:05 AM
jasonliu added a comment.May 5 2021, 11:52 AM

Gentle ping.

ldionne accepted this revision.May 7 2021, 11:15 AM
This revision is now accepted and ready to land.May 7 2021, 11:15 AM
Closed by commit rG4677d795b204: [libc++][AIX] Define _LIBCPP_ELAST (authored by jasonliu). · Explain WhyMay 10 2021, 6:54 AM
This revision was automatically updated to reflect the committed changes.
jasonliu added a commit: rG4677d795b204: [libc++][AIX] Define _LIBCPP_ELAST.
Herald added a project: Restricted Project. · View Herald TranscriptMay 10 2021, 6:54 AM
Herald added a subscriber: libcxx-commits. · View Herald Transcript

Revision Contents

PathSize
libcxx/
src/
include/
2 lines

Diff 339337

libcxx/src/include/config_elast.h

Show All 33 Lines
#elif defined(__APPLE__) #elif defined(__APPLE__)
// No _LIBCPP_ELAST needed on Apple // No _LIBCPP_ELAST needed on Apple
#elif defined(__sun__) #elif defined(__sun__)
#define _LIBCPP_ELAST ESTALE #define _LIBCPP_ELAST ESTALE
#elif defined(__MVS__) #elif defined(__MVS__)
#define _LIBCPP_ELAST 1160 #define _LIBCPP_ELAST 1160
#elif defined(_LIBCPP_MSVCRT_LIKE) #elif defined(_LIBCPP_MSVCRT_LIKE)
#define _LIBCPP_ELAST (_sys_nerr - 1) #define _LIBCPP_ELAST (_sys_nerr - 1)
#elif defined(_AIX)
#define _LIBCPP_ELAST 127
SeanPUnsubmitted
Not Done
ReplyInline Actions

AIX has sys_nerr. It would be better to use that.

SeanP: AIX has sys_nerr. It would be better to use that.
jasonliuAuthorUnsubmitted
Done
ReplyInline Actions

@SeanP sys_nerr is guarded by _ALL_SOURCE and it's a BSD extension. Since this is a header could potentially included by any source file, the _ALL_SOURCE requirement for building the source could get viral. I think we should decrease our exposure on needing _ALL_SOURCE to build the source.

jasonliu: @SeanP sys_nerr is guarded by `_ALL_SOURCE` and it's a BSD extension. Since this is a header…
#else #else
// Warn here so that the person doing the libcxx port has an easier time: // Warn here so that the person doing the libcxx port has an easier time:
#warning ELAST for this platform not yet implemented #warning ELAST for this platform not yet implemented
#endif #endif
#endif // _LIBCPP_CONFIG_ELAST #endif // _LIBCPP_CONFIG_ELAST