Page MenuHomePhabricator

Make dependency between certain analysis passes transitive
ClosedPublic

Authored by bjope on Wed, Apr 21, 7:29 AM.

Details

Summary

LazyBlockFrequenceInfoPass, LazyBranchProbabilityInfoPass and
LoopAccessLegacyAnalysis all cache pointers to their nestled required
analysis passes. One need to use addRequiredTransitive to describe
that the nestled passes can't be freed until those analysis passes
no longer are used themselves.

There is still a bit of a mess considering the getLazyBPIAnalysisUsage
and getLazyBFIAnalysisUsage functions. Those functions are used from
both Transform, CodeGen and Analysis passes. I figure it is OK to
use addRequiredTransitive also when being used from Transform and
CodeGen passes. On the other hand, I figure we must to do it when
used from other Analysis passes. So using addRequiredTransitive should
be more correct here. An alternative solution would be to add a
bool option in those functions to let the user tell if it is a
analysis pass or not. Since those lazy passes will be obsolete when
new PM has conquered the world I figure we can leave it like this
right now.

Intention with the patch is to fix PR49950. It at least solves the
problem for the reproducer in PR49950. However, that reproducer
need five passes in a specific order, so there are lots of various
"solutions" that could avoid the crash without actually fixing the
root cause.

Diff Detail

Event Timeline

bjope created this revision.Wed, Apr 21, 7:29 AM
bjope requested review of this revision.Wed, Apr 21, 7:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptWed, Apr 21, 7:29 AM
Herald added a subscriber: wdng. · View Herald Transcript
This revision was not accepted when it landed; it landed in state Needs Review.Tue, May 4, 2:52 AM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.