This is an archive of the discontinued LLVM Phabricator instance.

Can you say a few words on _why_ this is emitted in only Objective-C? What's missing for Objective-C++? I was surprised that this warning fired in a .m file but not in a .mm file.

Herald added a project: Restricted Project. · View Herald TranscriptJan 15 2023, 6:11 AM

In D100955#4054569, @thakis wrote:

Can you say a few words on _why_ this is emitted in only Objective-C? What's missing for Objective-C++? I was surprised that this warning fired in a .m file but not in a .mm file.

Technically there is nothing that prevents us from supporting Objective-C++, but the warning implementation will need to handle it correctly. Currently, it doesn't support lambda expressions and C++ exceptions from the top of my head. Probably there are more language constructs that can cause incorrect warnings. Long story short, it needs additional logic and testing.

Cheers!

Revision Contents

Path

Size

clang/

lib/

Sema/

AnalysisBasedWarnings.cpp

2 lines

test/

SemaObjCXX/

warn-called-once.mm

8 lines

Diff 339580

clang/lib/Sema/AnalysisBasedWarnings.cpp

Show First 20 Lines • Show All 2,397 Lines • ▼ Show 20 Lines	if (CFG *cfg = AC.getCFG()) {
MaxUninitAnalysisBlockVisitsPerFunction =		MaxUninitAnalysisBlockVisitsPerFunction =
std::max(MaxUninitAnalysisBlockVisitsPerFunction,		std::max(MaxUninitAnalysisBlockVisitsPerFunction,
stats.NumBlockVisits);		stats.NumBlockVisits);
}		}
}		}
}		}

// Check for violations of "called once" parameter properties.		// Check for violations of "called once" parameter properties.
if (S.getLangOpts().ObjC &&		if (S.getLangOpts().ObjC && !S.getLangOpts().CPlusPlus &&
shouldAnalyzeCalledOnceParameters(Diags, D->getBeginLoc())) {		shouldAnalyzeCalledOnceParameters(Diags, D->getBeginLoc())) {
if (AC.getCFG()) {		if (AC.getCFG()) {
CalledOnceCheckReporter Reporter(S, IPData->CalledOnceData);		CalledOnceCheckReporter Reporter(S, IPData->CalledOnceData);
checkCalledOnceParameters(		checkCalledOnceParameters(
AC, Reporter,		AC, Reporter,
shouldAnalyzeCalledOnceConventions(Diags, D->getBeginLoc()));		shouldAnalyzeCalledOnceConventions(Diags, D->getBeginLoc()));
}		}
}		}
▲ Show 20 Lines • Show All 81 Lines • Show Last 20 Lines

clang/test/SemaObjCXX/warn-called-once.mm

	// RUN: %clang_cc1 -verify -fsyntax-only -Wcompletion-handler %s			// RUN: %clang_cc1 -verify -fsyntax-only -fblocks -Wcompletion-handler %s

	// expected-no-diagnostics			// expected-no-diagnostics

	class HasCtor {			class HasCtor {
	HasCtor(void *) {}			HasCtor(void *) {}
	};			};

				void double_call_one_block(void (^completionHandler)(void)) {
				completionHandler();
				completionHandler();
				// no-warning - we don't support C++/Obj-C++ yet
				}

This is an archive of the discontinued LLVM Phabricator instance.

[-Wcalled-once] Do not run analysis on Obj-C++ClosedPublic

Details

Diff Detail

Event Timeline

Revision Contents

Diff 339580

clang/lib/Sema/AnalysisBasedWarnings.cpp

clang/test/SemaObjCXX/warn-called-once.mm

[-Wcalled-once] Do not run analysis on Obj-C++
ClosedPublic