Page MenuHomePhabricator
Differential D100754

[llvm-rc] [2/4] Fix handling of the /X option to match its documentation and rc.exe
ClosedPublic
Actions

Authored by mstorsjo on Apr 19 2021, 5:16 AM.

Details

Reviewers
rnk
thakis
amccarth
aganea
Commits
rG73cda4d18350: [llvm-rc] Fix handling of the /X option to match its documentation and rc.exe
Summary

This matches how it's documented in the option listing.

Diff Detail

Event Timeline

mstorsjo requested review of this revision.Apr 19 2021, 5:16 AM
mstorsjo created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptApr 19 2021, 5:16 AM
mstorsjo added a parent revision: D100753: [llvm-rc] [1/4] Simplify Opts.td to avoid repetition. NFC..Apr 19 2021, 5:16 AM
mstorsjo added a child revision: D100755: [llvm-rc] [3/4] Run clang to preprocess input files.Apr 19 2021, 5:22 AM
Harbormaster completed remote builds in B99455: Diff 338488.Apr 19 2021, 6:25 AM
rnk accepted this revision.Apr 19 2021, 1:47 PM

lgtm

This revision is now accepted and ready to land.Apr 19 2021, 1:47 PM
This revision was landed with ongoing or failed builds.Apr 19 2021, 11:25 PM
Closed by commit rG73cda4d18350: [llvm-rc] Fix handling of the /X option to match its documentation and rc.exe (authored by mstorsjo). · Explain Why
This revision was automatically updated to reflect the committed changes.
mstorsjo added a commit: rG73cda4d18350: [llvm-rc] Fix handling of the /X option to match its documentation and rc.exe.

Revision Contents
Changeset List

PathSize
llvm/
test/
tools/
llvm-rc/
10 lines
tools/
llvm-rc/
2 lines
9 lines
2 lines

Diff 338723

View Options

llvm/test/tools/llvm-rc/include-paths.test

Loading...
View Options

llvm/tools/llvm-rc/ResourceFileWriter.h

Loading...
View Options

llvm/tools/llvm-rc/ResourceFileWriter.cpp

Loading...
View Options

llvm/tools/llvm-rc/llvm-rc.cpp

Loading...