Page MenuHomePhabricator

[Docs] Mention LLVM_EXPERIMENTAL_TARGETS_TO_BUILD variable in CMake.rst
ClosedPublic

Authored by xgupta on Apr 18 2021, 10:58 AM.

Details

Summary

Beginners might not aware of this variable and wanted to try a new experimental target.

Although this variable mention in Writing a Backend Documentation. But it becomes easy to search when listed in cmake.rst doc where most variables are listed.

Diff Detail

Event Timeline

xgupta created this revision.Apr 18 2021, 10:58 AM
xgupta requested review of this revision.Apr 18 2021, 10:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 18 2021, 10:58 AM

Can we add some words on how to find valid values to set this to?

Actually, I don't know/find a way to list all experimental targets, @myhsu might aware of such an option as he is actively working on experimental target M68k.

Can we add some words on how to find valid values to set this to?

IIRC LLVM doesn't have a list of experimental targets in any of the CMake files (LLVM only has a list of targets built by default). The only way to find out is subtracting all folder names under llvm/lib/Target by the value of LLVM_ALL_TARGETS cmake variable inside llvm/CMakeLists.txt

Yeah, I also think this is the only way to know experimental targets.

Please accept the revision if it looks good.

myhsu added inline comments.Apr 19 2021, 2:15 PM
llvm/docs/CMake.rst
232

I don't think we should mention LLVM_ALL_TARGETS here since it's an internal variable.

xgupta updated this revision to Diff 338685.Apr 19 2021, 7:26 PM

Completely agree, remove the LLVM_ALL_TARGETS variable from the wording.

xgupta marked an inline comment as done.Apr 19 2021, 7:26 PM
xgupta updated this revision to Diff 338687.Apr 19 2021, 7:29 PM
myhsu accepted this revision.Apr 19 2021, 8:46 PM

LGTM

This revision is now accepted and ready to land.Apr 19 2021, 8:46 PM