This is an archive of the discontinued LLVM Phabricator instance.

In D100657#2695069, @sivachandra wrote:

FYI this has caused widespread redness in the bots. The fixes seem to be straightforward so I do not think we need to revert.

Actually, I take it back that we do not need to revert. We need to revert because std::rotate in used in Hashing.h.

hliao added a reverting change: rG853da5977e74: Revert "[Support] Don't include <algorithm> in Hashing.h".Apr 16 2021, 9:19 AM

Thanks for the revert, and sorry about missing this.

(It built fine locally, but that's very c++ standard-lib dependent of course.)

In D100657#2695067, @NathanielMcVicar wrote:

This broke the Windows MLIR buildbot, because algorithm is required for std::min in MSVC.
https://lab.llvm.org/buildbot/#/builders/13/builds/6985/steps/6/logs/stdio

(For this one, the Right Fix would be to add the include in APInt.h , or arguably undo parts of http://reviews.llvm.org/rG405165210b0b2f95e08d84ffcaab534fbd022fde , but since Hashing.h does use std::rotate() it needs to keep the include.)

Harbormaster completed remote builds in B99199: Diff 338143.Apr 16 2021, 11:17 AM

Revision Contents

Path

Size

llvm/

include/

llvm/

ADT/

Hashing.h

1 line

Diff 338143

llvm/include/llvm/ADT/Hashing.h

	Show First 20 Lines • Show All 42 Lines • ▼ Show 20 Lines

	#ifndef LLVM_ADT_HASHING_H			#ifndef LLVM_ADT_HASHING_H
	#define LLVM_ADT_HASHING_H			#define LLVM_ADT_HASHING_H

	#include "llvm/Support/DataTypes.h"			#include "llvm/Support/DataTypes.h"
	#include "llvm/Support/ErrorHandling.h"			#include "llvm/Support/ErrorHandling.h"
	#include "llvm/Support/SwapByteOrder.h"			#include "llvm/Support/SwapByteOrder.h"
	#include "llvm/Support/type_traits.h"			#include "llvm/Support/type_traits.h"
	#include <algorithm>
	#include <cassert>			#include <cassert>
	#include <cstring>			#include <cstring>
	#include <string>			#include <string>
	#include <tuple>			#include <tuple>
	#include <utility>			#include <utility>

	namespace llvm {			namespace llvm {

	▲ Show 20 Lines • Show All 623 Lines • Show Last 20 Lines

This is an archive of the discontinued LLVM Phabricator instance.

[Support] Don't include <algorithm> in Hashing.hClosedPublic

Details

Diff Detail

Event Timeline

Revision Contents

Diff 338143

llvm/include/llvm/ADT/Hashing.h

[Support] Don't include <algorithm> in Hashing.h
ClosedPublic