Page MenuHomePhabricator

[clangd] Only allow remote index to be enabled from user config.
ClosedPublic

Authored by sammccall on Apr 15 2021, 3:53 AM.

Diff Detail

Event Timeline

sammccall created this revision.Apr 15 2021, 3:53 AM
sammccall requested review of this revision.Apr 15 2021, 3:53 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 15 2021, 3:53 AM
kadircet accepted this revision.Apr 15 2021, 4:24 AM

thanks, lgtm!

clang-tools-extra/clangd/ConfigProvider.cpp
75

please fix

clang-tools-extra/clangd/unittests/ConfigCompileTests.cpp
328

we always expect this message, as the check is performed at entry, right? (and we don't really emit diags for the other case anymore)

333

please fix

This revision is now accepted and ready to land.Apr 15 2021, 4:24 AM
This revision was landed with ongoing or failed builds.Apr 15 2021, 5:51 AM
This revision was automatically updated to reflect the committed changes.
sammccall marked an inline comment as done.