Page MenuHomePhabricator

Expose parseXInDimensionList() to the `DialectAsmParser`
ClosedPublic

Authored by mehdi_amini on Apr 13 2021, 6:25 PM.

Details

Summary

This allows custom types and attribute to parse a dimension list that
isn't necessarily terminated with xtype, for example something like:

#tf.shape<4x5>

Diff Detail

Event Timeline

mehdi_amini created this revision.Apr 13 2021, 6:25 PM
mehdi_amini requested review of this revision.Apr 13 2021, 6:25 PM
rriddle accepted this revision.Apr 13 2021, 6:32 PM
rriddle added inline comments.
mlir/include/mlir/IR/DialectImplementation.h
366

Can you rephrase element type to something like "jutxtaposed with an identifier" or something?

This revision is now accepted and ready to land.Apr 13 2021, 6:32 PM
This revision was landed with ongoing or failed builds.Apr 13 2021, 7:07 PM
This revision was automatically updated to reflect the committed changes.