This is an archive of the discontinued LLVM Phabricator instance.

Differential D100417

Fix resolution-err.ll
ClosedPublic

Authored by stella.stamenova on Apr 13 2021, 3:27 PM.

Details

Reviewers
None
Commits
rGbcef28621a87: Fix resolution-err.ll
Summary

chmod tries to be very helpful on some platforms and prevent naive mistakes, by warning the user. This results in the following error during the test:

chmod: ...resolution-err.ll.tmp.resolution.txt: new permissions are r--rw-rw-, not r--r--r--

To fix the test, call chmod with u.

Diff Detail

Event Timeline

stella.stamenova created this revision.Apr 13 2021, 3:27 PM
Herald added subscribers: steven_wu, hiraditya, emaste. · View Herald TranscriptApr 13 2021, 3:27 PM
stella.stamenova requested review of this revision.Apr 13 2021, 3:27 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 13 2021, 3:27 PM
Herald added subscribers: llvm-commits, MaskRay. · View Herald Transcript
This revision was not accepted when it landed; it landed in state Needs Review.Apr 13 2021, 4:13 PM
This revision was landed with ongoing or failed builds.
Closed by commit rGbcef28621a87: Fix resolution-err.ll (authored by stella.stamenova). · Explain Why
This revision was automatically updated to reflect the committed changes.
stella.stamenova added a commit: rGbcef28621a87: Fix resolution-err.ll.
Harbormaster completed remote builds in B98568: Diff 337271.Apr 13 2021, 8:37 PM

Revision Contents

PathSize
lld/
test/
ELF/
lto/
2 lines

Diff 337284

lld/test/ELF/lto/resolution-err.ll

; UNSUPPORTED: system-windows ; UNSUPPORTED: system-windows
; REQUIRES: shell ; REQUIRES: shell
; RUN: llvm-as %s -o %t.bc ; RUN: llvm-as %s -o %t.bc
; RUN: touch %t.resolution.txt ; RUN: touch %t.resolution.txt
; RUN: chmod -w %t.resolution.txt ; RUN: chmod u-w %t.resolution.txt
; RUN: not ld.lld -save-temps %t.bc -o %t 2>&1 | FileCheck -DMSG=%errc_EACCES %s ; RUN: not ld.lld -save-temps %t.bc -o %t 2>&1 | FileCheck -DMSG=%errc_EACCES %s
; RUN: rm -f %t.resolution.txt ; RUN: rm -f %t.resolution.txt
; CHECK: error: [[MSG]] ; CHECK: error: [[MSG]]
target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128" target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu" target triple = "x86_64-unknown-linux-gnu"
define void @_start() { define void @_start() {
ret void ret void
} }