Page MenuHomePhabricator

[lldb-vscode] Add postRunCommands
ClosedPublic

Authored by wallace on Mon, Apr 12, 1:05 PM.

Details

Summary

This diff ass postRunCommands, which are the counterpart of the preRunCommands. TThey will be executed right after the target is launched or attached correctly, which means that the targets can assume that the target is running.

Diff Detail

Event Timeline

wallace requested review of this revision.Mon, Apr 12, 1:05 PM
wallace created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptMon, Apr 12, 1:05 PM
kusmour accepted this revision.Thu, Apr 15, 2:36 PM
This revision is now accepted and ready to land.Thu, Apr 15, 2:36 PM

"postRunCommands" might be clearer as "firstStopCommands"? Not sure, but I wanted to mention it.

lldb/tools/lldb-vscode/package.json
166
247
This revision was landed with ongoing or failed builds.Wed, Apr 21, 1:51 PM
This revision was automatically updated to reflect the committed changes.

It has caused a regression for Fedora buildbot (which is so far a silent one):
https://lab.llvm.org/staging/#/builders/16/builds/4936

Failed Tests (2):
  lldb-api :: tools/lldb-vscode/attach/TestVSCode_attach.py
  lldb-api :: tools/lldb-vscode/launch/TestVSCode_launch.py

I will check it more.

The regression was due to the help process trace command which surprisingly ends up in GDBRemoteCommunicationClient::SendTraceSupported which was crashing on libipt-enabled builds. Fixed by: rG18a85276426b9604a9ceca8c528b694964dd8d7c