Page MenuHomePhabricator

[CSSPGO] Exclude pseudo probes from slot index
ClosedPublic

Authored by hoy on Mon, Apr 12, 12:04 PM.

Details

Summary

Pseudo probe are currently given a slot index like other regular instructions. This affects register pressure and lifetime weight computation because of enlarged lifetime length with pseudo probe instructions. As a consequence, program could get different code generated w/ and w/o pseudo probes. I'm closing the gap by excluding pseudo probes from stack index and downstream register allocation related passes.

Diff Detail

Event Timeline

hoy created this revision.Mon, Apr 12, 12:04 PM
hoy requested review of this revision.Mon, Apr 12, 12:04 PM
Herald added a project: Restricted Project. · View Herald TranscriptMon, Apr 12, 12:04 PM
hoy updated this revision to Diff 336930.Mon, Apr 12, 12:13 PM

Updating D100334: [CSSPGO] Exclude pseudo probes from slot index

wmi accepted this revision.Sun, Apr 18, 10:11 PM

LGTM.

This revision is now accepted and ready to land.Sun, Apr 18, 10:11 PM
This revision was automatically updated to reflect the committed changes.