Page MenuHomePhabricator

LLJITWithRemoteDebugger: fix CMake when utils are not built
ClosedPublic

Authored by LittleFox94 on Apr 7 2021, 6:38 PM.

Details

Reviewers
sgraenitz
Summary

Currently configuration with cmake without building utils (LLVM_INCLUDE_UTILS) fails because that example depends on a util, llvm-jitlink-executor.

This patch only adds the example when utils are built. Note, I also had examples disabled - but this does not prevent their subdirectories being added - maybe this is another task.

Diff Detail

Event Timeline

LittleFox94 created this revision.Apr 7 2021, 6:38 PM
LittleFox94 requested review of this revision.Apr 7 2021, 6:38 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 7 2021, 6:38 PM

formatting was bad and somehow differential didn't show the endif() - added a trailing newline for that

Harbormaster completed remote builds in B97632: Diff 335971.
LittleFox94 added a subscriber: chandlerc.

Adding @chandlerc as a reviewer since first entry in CODE_OWNERS for CMake ^^'

LittleFox94 edited reviewers, added: sgraenitz; removed: chandlerc.Jun 25 2021, 4:53 PM

Change reviewer to author of file - might be the better option than code_owners

(also, ping)

Thanks for fixing this. Looks good to me!

Side-note: I think lljit-with-remote-debugging.test needs no change, because LLVM_INCLUDE_TESTS always requires LLVM_INCLUDE_UTILS.

llvm/examples/OrcV2Examples/LLJITWithRemoteDebugging/CMakeLists.txt
12

Is this a whitespace change?

sgraenitz accepted this revision.Jun 26 2021, 5:07 AM
This revision is now accepted and ready to land.Jun 26 2021, 5:07 AM

Thanks for your review :)

I cannot commit to the repository myself, can you commit this for me?
Author for commit: Mara Sophie Grosch <littlefox@lf-net.org>

llvm/examples/OrcV2Examples/LLJITWithRemoteDebugging/CMakeLists.txt
12

no idea, in my git commit that line is unchanged o.o

Got three buildbot failure mails with only me in the blamelist (thats a first), but they don't look like they are related to the change, but rather the build server having killed the compiler?

https://lab.llvm.org/buildbot/#/builders/93/builds/3697/steps/4/logs/stdio starting line 4768
https://lab.llvm.org/buildbot/#/builders/52/builds/8779/steps/4/logs/stdio starting line 4720
https://lab.llvm.org/buildbot/#/builders/100/builds/6803/steps/6/logs/stdio starting line 4831

just to be sure, any action required by me?

Got three buildbot failure mails with only me in the blamelist (thats a first), but they don't look like they are related to the change, but rather the build server having killed the compiler?
just to be sure, any action required by me?

I think the builds were killed by timeout. Previous ones only took a few minutes because they could run incrementally. The CMake change, however, triggered full rebuilds and apparently they took longer than expected. Subsequent builds were fine again (and fast). Maybe you could forward the failure mails to the bot owners with a note that they might want to revisit timeouts for non-incremental runs. Bot owners might be cc'd in the mails already or otherwise see the "owner" field the "Build Properties" tab. Thanks!