Page MenuHomePhabricator

[Sanitizer] Fix ccache not found and unbound variable errors
AbandonedPublic

Authored by Conanap on Apr 7 2021, 7:53 AM.

Details

Summary

I noticed a ccache: command not found error and this fixes that by checking the utility is available before running it.

Diff Detail

Event Timeline

Conanap created this revision.Apr 7 2021, 7:53 AM
Conanap requested review of this revision.Apr 7 2021, 7:53 AM
Conanap updated this revision to Diff 335813.Apr 7 2021, 8:05 AM

removed incorrect brackets

Sorry to ping you @gkistanova; this one is a bit urgent though. Thanks!

lei accepted this revision.Apr 8 2021, 6:54 AM
lei added a subscriber: lei.

LGTM

This revision is now accepted and ready to land.Apr 8 2021, 6:54 AM
Conanap closed this revision.Apr 8 2021, 7:18 AM

pushed

Conanap updated this revision to Diff 336106.Apr 8 2021, 7:43 AM
Conanap edited the summary of this revision. (Show Details)

Another person had made the same fix for the CMAKE_ARGS variable declaration, so this just adds a conditional to ccache. No longer an urgent issue.

Conanap reopened this revision.Apr 8 2021, 7:43 AM
This revision is now accepted and ready to land.Apr 8 2021, 7:43 AM
Conanap abandoned this revision.Tue, Apr 13, 8:17 AM

This doesn't actually seem to affect buildbot's operations so the changes is not likely needed.