Page MenuHomePhabricator

[mlir] verify that operand/result_segment_sizes attributes have i32 element
ClosedPublic

Authored by ftynse on Tue, Mar 23, 6:05 AM.

Details

Summary

This is an assumption that is made in numerous places in the code. In
particular, in the code generated by mlir-tblgen for operand/result accessors
in ops with attr-sized operand or result lists. Make sure to verify this
assumption.

Note that the operation traits are verified before running the custom op
verifier, which can expect the trait verifier to have passed, but some traits
may be verified before the AttrSizedOperand/ResultTrait and should not make
such assumptions.

Diff Detail

Event Timeline

ftynse created this revision.Tue, Mar 23, 6:05 AM
ftynse requested review of this revision.Tue, Mar 23, 6:05 AM
mehdi_amini accepted this revision.Tue, Mar 23, 10:20 AM
This revision is now accepted and ready to land.Tue, Mar 23, 10:20 AM